π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in markdown rendering#1254
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in markdown rendering#1254khangnghiem wants to merge 1 commit into
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
π¨ Severity: HIGH
π‘ Vulnerability: The output of
marked.parsefor rendering markdown notes insite/app.jswas directly interpolated intoinnerHTMLwithout sanitization, leaving the application vulnerable to XSS if a user could inject malicious HTML within the markdown content.π― Impact: An attacker could potentially inject malicious scripts that would execute in the context of the user's session when viewing a malicious markdown note, leading to session hijacking or unauthorized actions.
π§ Fix: Wrapped the
marked.parse(processedNote)output withwindow.DOMPurify ? window.DOMPurify.sanitize(rendered, { ADD_ATTR: ['data-note-node', 'data-node'] }) : fallbackto ensure the HTML is sanitized before assignment toinnerHTML, whilst gracefully preserving the application's required custom attributes. The fallback uses native regex escaping.β Verification: Ran
cargo check,cargo test,cargo clippy, andcargo fmtto verify no regressions in the core workspace, and verified JS syntax withnode --check.PR created automatically by Jules for task 17023163726940725422 started by @khangnghiem