Skip to content

fix: Log commands for better debugging #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epage merged 2 commits into from
May 27, 2025
Merged

fix: Log commands for better debugging #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25e262
fix: Log commands for better debugging
epage May 27, 2025
51eaa1e
style: Make clippy happy
epage May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/bin/upgrade/upgrade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,7 @@ fn exec(args: UpgradeArgs) -> CargoResult<()> {
cmd.arg("--package").arg(dep);
// If we're going to request an update, it would have already been done by now
cmd.arg("--offline");
log::trace!("Running {cmd:?}");
let output = cmd.output().context("failed to lock to precise version")?;
if !output.status.success() {
return Err(anyhow::format_err!(
Expand Down Expand Up @@ -547,6 +548,7 @@ fn exec(args: UpgradeArgs) -> CargoResult<()> {
}
// If we're going to request an update, it would have already been done by now
cmd.arg("--offline");
log::trace!("Running {cmd:?}");
let status = cmd.status().context("recursive dependency update failed")?;
if !status.success() {
anyhow::bail!("recursive dependency update failed");
Expand Down Expand Up @@ -583,6 +585,7 @@ fn exec(args: UpgradeArgs) -> CargoResult<()> {
// If we're going to request an update, it would have already been done by now
cmd.arg("--offline");
if still_run {
log::trace!("Running {cmd:?}");
let status = cmd.status().context("recursive dependency update failed")?;
if !status.success() {
anyhow::bail!("recursive dependency update failed");
Expand Down
4 changes: 2 additions & 2 deletions src/dependency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,8 +561,8 @@ impl std::fmt::Display for Dependency {

fn path_field(crate_root: &Path, abs_path: &Path) -> String {
let relpath = pathdiff::diff_paths(abs_path, crate_root).expect("both paths are absolute");
let relpath = relpath.to_str().unwrap().replace('\\', "/");
relpath

relpath.to_str().unwrap().replace('\\', "/")
}

/// Primary location of a dependency
Expand Down
Loading