[REFACTOR][HOTFIX] 52 support python38 for llama index packs#53
Open
seyeong-han wants to merge 2 commits into
Open
[REFACTOR][HOTFIX] 52 support python38 for llama index packs#53seyeong-han wants to merge 2 commits into
seyeong-han wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Llama-index uses
black,ruff,codespellonpre-commit.The reason why we got the error during their unit testing was their
unit testingalso checked our originalmemaryrepository even if we didn't put our library codes on thellama-index-packs.Therefore, we had to modify our original repo codes to pass their
pre-commit config.To @kevinl424,
We need to build the next version of
memary(i.e. v0.1.3.hotfix) on PyPI for llama-index-packs integration.After building the new version of
memary, please teststreamlit applicationagain. I carefully checked all the reformatted codes but there can be small mistakes.