Skip to content

Introduce KServe image builds #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

gorkem
Copy link
Contributor

@gorkem gorkem commented Apr 9, 2025

Introduces new docker image for kserve ClusterStorageContainer.
Fixes the documentation for the ClusterStorageContainer
Enhances README for usage.

fixes #817

@gorkem gorkem requested review from Copilot and amisevsk April 9, 2025 14:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • build/dockerfiles/KServe/Dockerfile: Language not supported
Comments suppressed due to low confidence (1)

build/dockerfiles/KServe/README.md:61

  • The sample build command uses the tag 'kit-init-container:latest', which is inconsistent with the new image name used elsewhere. Consider updating it to 'kitops-kserve:latest' for clarity and consistency.
docker build -t kit-init-container:latest --build-arg KIT_BASE_IMAGE=ghcr.io/kitops-ml/kitops:v1.3.0 .

Also fixes the documentation for the ClusterContainerStorage

Signed-off-by: Gorkem Ercan <[email protected]>
@gorkem gorkem merged commit 5bd91f1 into kitops-ml:main Apr 10, 2025
4 checks passed
@gorkem gorkem deleted the gorkem/issue817 branch April 10, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterStorageContainer with kit:// prefix and Kserve not working
2 participants