Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1107 LiveActivities instant updates fixes #1146

Merged
merged 8 commits into from
Mar 28, 2025

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1107

Make sure we handle background tasks.
Use more frequent updates, without timers, that the background task can cancel.
Do a direct update of live activities in scheduled background mode.
Fix the remaining time calculations.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 23.73%. Comparing base (0ea8330) to head (609dfe2).

Files with missing lines Patch % Lines
App/App_iOS.swift 0.00% 24 Missing ⚠️
Model/Utilities/DownloadTime.swift 0.00% 17 Missing ⚠️
Views/LiveActivity/ActivityService.swift 0.00% 11 Missing ⚠️
Model/Downloads/BackgroundDownloads.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1146       +/-   ##
===========================================
- Coverage   99.49%   23.73%   -75.76%     
===========================================
  Files          14      136      +122     
  Lines         785     7098     +6313     
===========================================
+ Hits          781     1685      +904     
- Misses          4     5413     +5409     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BPerlakiH BPerlakiH marked this pull request as ready for review March 28, 2025 13:25
@kelson42
Copy link
Contributor

@BPerlakiH Please make a new testflight once merged

@kelson42 kelson42 merged commit 1b98031 into main Mar 28, 2025
8 checks passed
@kelson42 kelson42 deleted the 1107-liveactivities-instant-updates branch March 28, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve LiveActivities
3 participants