Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Search Bar Placeholder Text Overflow. #1185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aditii2712
Copy link

@aditii2712 aditii2712 commented Mar 5, 2025

Fixes #1184

This PR fixes the issue where the placeholder text in the search bar was overflowing beyond the input field’s width. The fix ensures that the placeholder text stays within the search bar.

Screenshot including the fix:-

Screenshot 2025-03-06 at 1 09 14 AM

@aditii2712
Copy link
Author

@kelson42 Please take a look when get a chance.

Thanks!

@kelson42 kelson42 self-requested a review March 6, 2025 18:08
@kelson42
Copy link
Collaborator

kelson42 commented Mar 6, 2025

@aditii2712 Not a proper fix, it works here, but no garanty that it works with an other title.

@aditii2712
Copy link
Author

aditii2712 commented Mar 7, 2025

@kelson42 Regret, I had missed that we're using the same header across the application.

I've implemented another fix for the placeholder text overflow in the search box by:

  1. Using text truncation for the over-flowing text with ellipsis (...)
  2. Also, adjusted the responsive width parameters for better display across device sizes

PTAL when you get a chance..

Adding a vid to show the updates.

Screen.Recording.2025-03-07.at.2.13.45.PM.mov

@aditii2712
Copy link
Author

@kelson42 Please take a look when get a chance.

@aditii2712
Copy link
Author

Hi @kelson42, Would appreciate your review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Bar Placeholder Text Overflows Outside the Input Field
2 participants