Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor xmap and fix bug #17

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Refactor xmap and fix bug #17

merged 4 commits into from
Jan 13, 2025

Conversation

kkew3
Copy link
Owner

@kkew3 kkew3 commented Jan 13, 2025

Summary:

  • Refactor the xmap wrapper to make it cleaner.
  • Fix (partially) a bug introduced in commit 2e83b1a.

Despite fixed partially, the remaining bug should not cause significant issue. Quoted from code:

Current handling does not cover every edge case, especially the case where the cursor is at the last character of the buffer in visual line mode. I'm aware of it, and intentionally mark test/cases/xmap_ge_eol.vader.j2 as IGNORED. Generally speaking, the failed case (which involves motion ge in visual line mode) does not have severe impact to users, as ge is rarely used. Some plugins, e.g. preservim/vim-markdown, even remaps it to certain plugin function. Therefore, this might be fixed in the future, but with a relatively low priority.

kkew3 added 4 commits January 13, 2025 18:18
Commit 2e83b1a attempted to fix an edge case in xmap ge motion, but introduced a severer issue, which is tackled in this commit. See test/cases/xmap_back_empty_line.vader.j2 for details.
@kkew3 kkew3 merged commit 5cea325 into rust Jan 13, 2025
6 checks passed
@kkew3 kkew3 deleted the refactor-xmap branch January 13, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant