Skip to content

fix: wrap socket.error exceptions in ConnectionError for consistent exception handling#66

Open
label-hook[bot] wants to merge 1391 commits into
mainfrom
phoenix/issue-65
Open

fix: wrap socket.error exceptions in ConnectionError for consistent exception handling#66
label-hook[bot] wants to merge 1391 commits into
mainfrom
phoenix/issue-65

Conversation

@label-hook

@label-hook label-hook Bot commented Apr 13, 2026

Copy link
Copy Markdown

Summary

This PR addresses issue #65 where raw socket.error exceptions were being raised instead of being wrapped in requests.exceptions.ConnectionError. This change ensures consistent exception handling by wrapping socket-level errors in the appropriate requests exception type.

Changes

  • Modified HTTPAdapter.send() method in requests/adapters.py to catch socket.error exceptions
  • Added exception wrapping to convert socket.error to requests.exceptions.ConnectionError
  • Maintains the original exception as the cause for debugging purposes
  • Ensures all socket-level connection issues are presented as requests exceptions rather than raw socket errors

Testing

The changes were tested to ensure:

  • Socket errors are properly caught and wrapped in ConnectionError
  • Original exception information is preserved for debugging
  • No regression in existing functionality
  • Baseline test suite continues to pass (no new failures introduced)

Closes #65

Closes #65

Lukasa and others added 30 commits January 9, 2014 19:50
@Lukasa
Fixup the header heirarchy.
ac4e058
@Lukasa
Unquote the auth after splitting the url.
ca187ab
@Lukasa
TypeError, not AttributeError on 3.3.
dddb41e
@Lukasa
Meet @sigmavirus24's demanding stylistic criteria.
b4ca6c9
@Lukasa
Be less defensive in get_auth_from_url.
2f98ef1
@Lukasa
Don't need to unquote twice.
5b4e9af
@sybeck2k
Fixed parsing of username and password encoded in the URI
a6a8342
@sybeck2k
Merged changes from @Lukasa
49fb630
@sybeck2k
Added comment for test test_get_auth_from_url
eb12435
@kennethreitz
Merge pull request psf#1862 from sybeck2k/master
0465d34 
Fixed parsing of username and password encoded in the URI
@Lukasa
Document contextlib.closing.
476ab20
@kennethreitz
Merge pull request psf#1867 from Lukasa/closing
57c71ec 
Document contextlib.closing.
@kennethreitz
Update NOTICE
c305586
@sigmavirus24
Add a small note about requests-toolbelt
799bf11
Typo in History
f17ead4
@Lukasa
Merge pull request psf#1874 from kevinburke/typo
4872f46 
Typo in History
@sigmavirus24
Add missing sled
3bd16ce 
Thanks @kevinburke
@Lukasa
Update changelog for 2.2.1.
2a6b835
@dstufft
Update urllib3 to 9346c5c
d181577
@kennethreitz
Merge pull request psf#1876 from dstufft/update-urllib3
a5b3719 
Update urllib3 to 9346c5c
v2.2.1
3373548
@kennethreitz
Merge pull request psf#1870 from sigmavirus24/add-toolbelt-to-docs
7773b27 
Add a small note about requests-toolbelt
NOTICE update
06ecae4
s/soley/solely
4c11fb7
@sigmavirus24
Merge pull request psf#1881 from kevinburke/typo
42b8a6d 
s/soley/solely
@meteozond
Added info about posted files headers
1e3eb4e
@Lukasa
Merge pull request psf#1886 from meteozond/patch-1
19756d5 
Added info about posted files headers
@kouk
test pyopenssl redirect (unit test for psf#1887)
b6e1679
@kouk
on redirect pass URL as bytes. Fixes: psf#1887
8b792be
@kennethreitz
Merge pull request psf#1888 from longaccess/handle301
b1c8fd3 
Fix for 301 redirect and latest PyOpenSSL.
nonZero and others added 26 commits July 15, 2014 19:56
@nonZero
removed unneeded parentheses from if clause
6dc13f2
@sigmavirus24
Merge pull request psf#2133 from esparta/master
54fc807 
Update link to pip site on docs/user/install.rst
@sigmavirus24
Merge pull request psf#2134 from nonZero/patch-1
d21916c 
removed unneeded parentheses from if clause
@dpursehouse
Docs: Fix :class: and :meth: directives
2a6303e 
A few instances of the directives were malformed and did not
result in hyperlinks in the generated HTML.

Change-Id: I94d93de928ee4ff24a48797baf2ac77598a20704
@Lukasa
Merge pull request psf#2135 from dpursehouse/fix-meth-and-class-direc…
e25fbc8 
…tives

Docs: Fix :class: and :meth: directives
@dpursehouse
Fix name misspelling
f0fb20c 
Change-Id: Ied3e600e5673eff48558b634b3c2616d13a3337b
@sigmavirus24
Merge pull request psf#2136 from dpursehouse/greenfeld-not-greenfield
999ba49 
Fix name misspelling
@dpursehouse
Add authentication classes to the API document
49ecffb 
Change-Id: Ic1464f246602b809f3c29fbafd6f36b747d5d5df
@dpursehouse
Fix a couple more malformed :meth: and :class: links
c6fa5bb 
Change-Id: Ie38844a40ec7a483e6ce5e56077be344242bcd99
@dpursehouse
Remove redundant sentence from quickstart introduction
1785278 
Change-Id: Ic03aa394941367745f3148d299b5313849f77051
@dpursehouse
Remove empty 'internals' page
be453ba 
The file is empty and not linked from anywhere, resulting in
a warning when building the docs.

Change-Id: Ib995d094ef525496fe8b2a369e0a0c5b4c7bd2dd
@Lukasa
Merge pull request psf#2138 from dpursehouse/more-doc-updates
587a515 
More doc updates
@dpursehouse
More line wrapping
44e426e 
Change-Id: I950c3da727fb97b58d96a872b0d2ed718cc60ba8
@dpursehouse
Linkify Github usernames in authors list
743f382 
- Linkify github usernames
- Remove usernames that do not exist

Change-Id: Ib88b70a3010e915b3570ae5062c8cb416c9a6462
@Lukasa
Merge pull request psf#2139 from dpursehouse/line-wrapping
4c94282 
More line wrapping
@dpursehouse
Add links to Twitter accounts
eef4e08 
Change-Id: Ic88eb128384b3cc9108151c219cd759c7524a4f1
@esparta
Docs: Using print() function instead print command on advanced & quic…
698b93b 
…kstart user docs
@Lukasa
Merge pull request psf#2141 from esparta/master
e66466a 
Docs: Using print() function instead print command on advanced & quickstart
@sigmavirus24
Upgrade urllib3 to 1.9.x
811ee4e
@sigmavirus24
Fix test bug courtesy of @shazow
170d626
@Lukasa
Merge pull request psf#2140 from dpursehouse/linkify-usernames
eb2906a 
Linkify Github usernames in authors list
@TkTech
Update faq.rst
57b8611 
Removed an unnecessary "to" in the "What are "hostname doesn't match" errors?" section.
@TkTech
Update faq.rst
35f7bcd 
Revised wording based on feedback from @sigmavirus24
@kennethreitz
Merge pull request psf#2145 from TkTech/patch-1
9575d6a 
Update faq.rst
@kennethreitz
Merge pull request psf#2142 from sigmavirus24/urllib3-1.9
fe693c4 
Upgrade urllib3 to 1.9.x
@kkipngenokoech
feat: wrap socket.error exceptions in ConnectionError for consistent …
9ebb45c 
…exception handling
@label-hook label-hook Bot added the ai:review Phoenix AI: PR ready for review label Apr 13, 2026
@label-hook label-hook Bot mentioned this pull request Apr 13, 2026
Open
@kkipngenokoech kkipngenokoech force-pushed the main branch 2 times, most recently from 36453b9 to a0df2cb Compare April 18, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ai:review Phoenix AI: PR ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SWE-bench] psf__requests-2148