fix: handle bytes objects properly in builtin_str for Python 3#83
Open
label-hook[bot] wants to merge 1522 commits into
Open
fix: handle bytes objects properly in builtin_str for Python 3#83label-hook[bot] wants to merge 1522 commits into
label-hook[bot] wants to merge 1522 commits into
Conversation
Don't repopulate proxies if we don't trust the environment.
There's not a lot of good reason to actually call out easy_install at all. Anyone who prefers it already knows it exists and everyone else should be directed unambiguously towards pip.
Remove the easy_install section
ImportError: No module named 'requests.packages.urllib3.util'
Update urllib3 to 4fb351cd2
Improved decoding support for Response.iter_content and iter_lines
Default proxy scheme to HTTP
Add __str__ to case insensitive dict
Catch errors while handling redirects
`Sesssion` -> `Session`
Fix typo in advanced.rst docs
Initial 2.3.0 changelog.
Fixed a typo
Re-order params for backwards compat
Fixed -2250
Add Release History to the sidebar
Fix issue psf#2279. "Gittip" changed to "Gratipay". Tip button extended from 48px to 60px.
Update sidebarintro.html
Fix psf#2288 . Change urllib3 and chardet workflow
Fix psf#2279. Update layout css
Adding a custom line delimiter to iter_lines()
This reverts commit cfd6e25.
This reverts commit 26ed7c2.
…e_unicode_url Fix failing test test_prepare_unicode_url
kkipngenokoech
force-pushed
the
main
branch
2 times, most recently
from
36453b9 to
a0df2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where
builtin_str()incorrectly converts bytes objects likeb'GET'to their string representation"b'GET'"instead of decoding them to the actual string'GET'. This was causing HTTP requests to fail with 404 errors when method names were passed as bytes objects in Python 3.Changes
builtin_str()function inrequests/compat.pyto detect bytes objects in Python 3 and decode them using UTF-8 encodingb'GET'to'GET'instead of"b'GET'"Testing
builtin_str(b'GET')returns'GET'in Python 3builtin_str('GET')still returns'GET'(no regression)Closes #82
Closes #82