-
Notifications
You must be signed in to change notification settings - Fork 3
Devnet redeployment #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update modifies multiple components across the repository. The deployment script now uses a mapping to resolve deployment names based on the network and fetches contract instances via a utility from Changes
Sequence Diagram(s)sequenceDiagram
participant DeployScript
participant HRE
participant Deployments
participant ContractsUtil
DeployScript->>HRE: Access Hardhat runtime environment
DeployScript->>Deployments: Get current network name
DeployScript->>ContractsUtil: getContractsEthers(provider, deploymentName)
ContractsUtil-->>DeployScript: Return contract instances (klerosCore, evidence, disputeTemplateRegistry)
DeployScript->>DeployScript: Use .target of contracts for deployment logic
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❌ Deploy Preview for curate-v2 failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
contracts/scripts/setDisputeTemplate.ts (1)
30-30
: Improved signer handling - good change!This update explicitly provides the deployer's signer address when getting the contract instance, ensuring all contract interactions use the correct signer. This approach is more explicit and aligns with the script's subsequent governor check at line 38.
Consider addressing the warning at the top of the file (lines 5-6) about hardcoded Devnet values in a future update as indicated in the comment.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (3)
contracts/README.md
(1 hunks)contracts/scripts/setDisputeTemplate.ts
(1 hunks)templates/index.ts
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- templates/index.ts
- contracts/README.md
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - curate-v2
- GitHub Check: Header rules - curate-v2
- GitHub Check: Pages changed - curate-v2
PR-Codex overview
This PR updates several components of the project, primarily focusing on upgrading Solidity versions, modifying contract addresses, and updating dependencies to improve functionality and compatibility.
Detailed summary
pragma solidity
version from0.8.18
to0.8.24
in multiple contracts.subgraph.yaml
andREADME.md
.startBlock
insubgraph.yaml
.arbitratorAddress
intemplates/index.ts
.viem
version from2.22.22
to2.27.2
inpackage.json
.package.json
files across the project.setDisputeTemplate.ts
to includegetContractAtWithSignerAddress
.Curate.ts
for dispute handling.Summary by CodeRabbit
Chores
Refactor
Bug Fixes