Skip to content

Update MessageSetDivinationResult.java#1486

Open
Eqis-Edu wants to merge 1 commit intoklikli-dev:version/1.21.1from
Eqis-Edu:1.21.1-fix.1485
Open

Update MessageSetDivinationResult.java#1486
Eqis-Edu wants to merge 1 commit intoklikli-dev:version/1.21.1from
Eqis-Edu:1.21.1-fix.1485

Conversation

@Eqis-Edu
Copy link
Contributor

@Eqis-Edu Eqis-Edu commented Feb 2, 2026

Fix #1485

The network message also check off-hand.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Eqis-Edu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where divination rod data was not being updated if the rod was held in the player's off-hand. The changes ensure that both main-hand and off-hand divination rods correctly receive and store their updated divination results, improving the reliability of the divination mechanic.

Highlights

  • Off-hand Divination Rod Support: Implemented logic to correctly update divination rod data (distance and position) when the rod is held in the player's off-hand, resolving an issue where only the main-hand item was considered.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds support for checking the off-hand for a divination rod. However, the implementation introduces duplicated code for handling the main and off-hand. I've suggested a refactoring to consolidate this logic, which will improve code maintainability by removing the repetition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Divination Rod and True Sight Staff not updating target when in off hand

1 participant