Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] Cherry-pick E2E tests for channel: TLS key pair rotation #3406 #3529

Merged

Conversation

Leo6Leo
Copy link
Contributor

@Leo6Leo Leo6Leo commented Dec 12, 2023

@knative-prow knative-prow bot requested review from creydr and pierDipi December 12, 2023 21:23
@knative-prow knative-prow bot added area/test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1e8b00) 58.48% compared to head (061589b) 58.52%.

❗ Current head 061589b differs from pull request most recent head 47fa4c8. Consider uploading reports for the commit 47fa4c8 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #3529      +/-   ##
================================================
+ Coverage         58.48%   58.52%   +0.04%     
================================================
  Files                91       91              
  Lines              9319     9328       +9     
================================================
+ Hits               5450     5459       +9     
  Misses             3433     3433              
  Partials            436      436              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo6Leo Leo6Leo force-pushed the cp-828b81e-release-1.12 branch from 061589b to 47fa4c8 Compare January 2, 2024 19:40
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jan 2, 2024

/hold Github action is using java 20, and prow is using java 21.

https://cloud-native.slack.com/archives/C04LMU33V1S/p1702650834729369?thread_ts=1702324625.563199&cid=C04LMU33V1S

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2024
@pierDipi
Copy link
Member

pierDipi commented Jan 3, 2024

/retest

2 similar comments
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jan 3, 2024

/retest

@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jan 5, 2024

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
Copy link

knative-prow bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@Cali0707
Copy link
Member

Hey @pierDipi @Leo6Leo can we unhold this PR now?

@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jan 11, 2024

/unhold Yes

@pierDipi
Copy link
Member

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2024
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jan 15, 2024

/retest-required

@creydr
Copy link
Contributor

creydr commented Jan 16, 2024

/retest

1 similar comment
@creydr
Copy link
Contributor

creydr commented Jan 16, 2024

/retest

@knative-prow knative-prow bot merged commit d2f4aee into knative-extensions:release-1.12 Jan 16, 2024
54 checks passed
Copy link

knative-prow bot commented Jan 16, 2024

@Leo6Leo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.12 47fa4c8 link true /test reconciler-tests-namespaced-broker

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane area/test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants