-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.12] Cherry-pick E2E tests for channel: TLS key pair rotation #3406 #3529
[release-1.12] Cherry-pick E2E tests for channel: TLS key pair rotation #3406 #3529
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #3529 +/- ##
================================================
+ Coverage 58.48% 58.52% +0.04%
================================================
Files 91 91
Lines 9319 9328 +9
================================================
+ Hits 5450 5459 +9
Misses 3433 3433
Partials 436 436 ☔ View full report in Codecov by Sentry. |
061589b
to
47fa4c8
Compare
/hold Github action is using java 20, and prow is using java 21. |
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold Yes |
/unhold |
/retest-required |
/retest |
1 similar comment
/retest |
d2f4aee
into
knative-extensions:release-1.12
@Leo6Leo: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cherry-pick https://github.com/knative-extensions/eventing-kafka-broker/pull/3406/files