Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2025 SC EU seat elections #1660

Merged
merged 10 commits into from
Feb 3, 2025
Merged

2025 SC EU seat elections #1660

merged 10 commits into from
Feb 3, 2025

Conversation

aliok
Copy link
Member

@aliok aliok commented Jan 27, 2025

Changes

/kind

Fixes #

Release Note

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 27, 2025

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from dsimansk and psschwei January 27, 2025 09:07
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@aliok
Copy link
Member Author

aliok commented Jan 27, 2025

cc @knative/steering-committee

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2025
dprotaso
dprotaso reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits for clarity

elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
aliok and others added 8 commits January 28, 2025 10:36
@aliok @dprotaso
Update elections/2025-SC-EU/README.md
e92e594 
Co-authored-by: Dave Protasowski <[email protected]>
@aliok @dprotaso
Update elections/2025-SC-EU/README.md
0873541 
Co-authored-by: Dave Protasowski <[email protected]>
@aliok @dprotaso
Update elections/2025-SC-EU/README.md
dc72768 
Co-authored-by: Dave Protasowski <[email protected]>
@aliok @dprotaso
Update elections/2025-SC-EU/README.md
915f9ea 
Co-authored-by: Dave Protasowski <[email protected]>
@aliok @dprotaso
Update elections/2025-SC-EU/README.md
814ccda 
Co-authored-by: Dave Protasowski <[email protected]>
@aliok @dprotaso
Update elections/2025-SC-EU/README.md
747ba82 
Co-authored-by: Dave Protasowski <[email protected]>
@aliok @dprotaso
Update elections/2025-SC-EU/README.md
95b20e6 
Co-authored-by: Dave Protasowski <[email protected]>
@aliok @dprotaso
Update elections/2025-SC-EU/README.md
f0996d2 
Co-authored-by: Dave Protasowski <[email protected]>
@aliok
Copy link
Member Author

aliok commented Jan 28, 2025

Thanks @dprotaso

@dprotaso
Copy link
Member

/lgtm
/approve

/hold for quorum

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
aliok
aliok commented Feb 3, 2025
View reviewed changes
elections/2025-SC-EU/README.md Outdated Show resolved Hide resolved
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
matzew
matzew approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, dprotaso, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aliok,dprotaso,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok
Copy link
Member Author

aliok commented Feb 3, 2025

/unhold

We have quorum.

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2025
@knative-prow knative-prow bot merged commit 2c5bcc9 into knative:main Feb 3, 2025
3 checks passed
@aliok aliok deleted the 2025-01-27-enduser-seat-election branch February 3, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@matzew matzew matzew approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@dprotaso dprotaso

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliok @dprotaso @matzew