Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Scheduler: log expected vreplicas by vpod #8461

Open
wants to merge 1 commit into
base: release-1.16
Choose a base branch
from

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #8449

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi February 13, 2025 12:14
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.95%. Comparing base (d59d3b6) to head (9a8c10b).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.16    #8461   +/-   ##
=============================================
  Coverage         64.94%   64.95%           
=============================================
  Files               359      359           
  Lines             22108    22112    +4     
=============================================
+ Hits              14359    14363    +4     
  Misses             6993     6993           
  Partials            756      756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025
Copy link

knative-prow bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@matzew
Copy link
Member

matzew commented Feb 14, 2025

/retest

2 similar comments
@matzew
Copy link
Member

matzew commented Feb 14, 2025

/retest

@matzew
Copy link
Member

matzew commented Feb 14, 2025

/retest

Copy link

knative-prow bot commented Feb 14, 2025

@knative-prow-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_release-1.16 9a8c10b link true /test reconciler-tests
conformance-tests_eventing_release-1.16 9a8c10b link true /test conformance-tests
upgrade-tests_eventing_release-1.16 9a8c10b link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants