Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic code for Certificates #8489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Generic code for Certificates #8489

wants to merge 1 commit into from
+111 −16

Conversation

matzew
Copy link
Member

@matzew matzew commented Feb 20, 2025

Fixes #

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2025
@knative-prow knative-prow bot requested review from aslom and creydr February 20, 2025 09:43
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.62%. Comparing base (51637df) to head (7c2ac01).

Files with missing lines Patch % Lines
...conciler/integration/sink/resources/certificate.go 0.00% 7 Missing ⚠️
pkg/reconciler/integration/sink/integrationsink.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8489   +/-   ##
=======================================
  Coverage   62.62%   62.62%           
=======================================
  Files         396      396           
  Lines       24231    24231           
=======================================
  Hits        15175    15175           
  Misses       8247     8247           
  Partials      809      809

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2025
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2025
@matzew matzew changed the title WIP: Generic code for Certificates Generic code for Certificates Feb 20, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
matzew
matzew commented Feb 20, 2025
View reviewed changes
pkg/reconciler/integration/sink/resources/certificate.go Outdated
)

func CertificateName(sinkName string) string {
return kmeta.ChildName(sinkName, "-server-tls")
}

func MakeCertificate(sink *v1alpha1.IntegrationSink) *cmv1.Certificate {
func MakeCertificate(sink kmeta.OwnerRefableAccessor, name string) *cmv1.Certificate {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi I found this as a way to pass in generic types

@matzew
Copy link
Member Author

matzew commented Feb 20, 2025

Should we move this to pkg/certificates ?

(and perhaps adding a simple test)

@matzew
Copy link
Member Author

matzew commented Feb 20, 2025

/test unit-tests

@matzew
Make Certifacte factory more generic
0009487 
Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2025
@matzew
Copy link
Member Author

matzew commented Feb 20, 2025

/test unit-tests

pierDipi
pierDipi approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/retest-required

@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 20, 2025

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing_main 0009487 link true /test unit-tests
reconciler-tests_eventing_main 0009487 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@aslom aslom Awaiting requested review from aslom

@creydr creydr Awaiting requested review from creydr

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matzew @pierDipi @knative-prow-robot