Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to render the helm chart 1.17.0 with default values.yaml file #1975

Closed
mymasse opened this issue Jan 28, 2025 · 2 comments · Fixed by #1985
Closed

Unable to render the helm chart 1.17.0 with default values.yaml file #1975

mymasse opened this issue Jan 28, 2025 · 2 comments · Fixed by #1985
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mymasse
Copy link

mymasse commented Jan 28, 2025

Describe the bug

Unable to deploy the chart when not overriding the values.

> helm template knative-operator https://github.com/knative/operator/releases/download/knative-v1.17.0/knative-operator-v1.17.0.tgz
Error: YAML parse error on knative-operator/templates/operator.yaml: error converting YAML to JSON: yaml: line 40: did not find expected key

Use --debug flag to render out invalid YAML

Expected behavior

Chart should render with no errors

To Reproduce

See above

Knative release version
1.17.0

Additional context

Passing the following values to the helm template works (essentially the 1.16.x chart equivalent)

knative_operator:
  knative_operator:
    affinity: null
  operator_webhook:
    affinity: null
@mymasse mymasse added the kind/bug Categorizes issue or PR as related to a bug. label Jan 28, 2025
@patrickleet
Copy link
Contributor

patrickleet commented Jan 29, 2025

the change is from #1962

@houshengbo
Copy link
Contributor

The 1.17.1 release has resolved this issue.

helm template knative-operator https://github.com/knative/operator/releases/download/knative-v1.17.0/knative-operator-v1.17.0.tgz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants