Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the indentation issue in the template #1985

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Jan 31, 2025

Fixes #1975

Proposed Changes

  • Fixed the indent issues in helm template.

Release Note


Copy link

knative-prow bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2025
@knative-prow knative-prow bot requested review from aliok and matzew January 31, 2025 21:08
@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@houshengbo
Copy link
Contributor Author

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (ef3db22) to head (d6b960f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1985   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files          54       54           
  Lines        2622     2622           
=======================================
  Hits         1675     1675           
  Misses        830      830           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit a879c4d into knative:main Jan 31, 2025
20 of 21 checks passed
@knative-prow-robot
Copy link
Contributor

@houshengbo: new pull request created: #1986

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to render the helm chart 1.17.0 with default values.yaml file
2 participants