UIEXT-3109: Migrate node #4
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the Excel Table Writer node to use the modern node parameter framework, replacing the legacy dialog implementation with declarative parameter definitions. The migration introduces type-safe parameter handling and modern UI capabilities while maintaining backward compatibility with existing workflows.
Key changes:
- Replaced legacy
NodeDialogPanewith declarativeNodeParametersclass - Added
@Labelannotations to enums for improved UI presentation - Implemented comprehensive unit tests for the new parameter structure
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| PaperSize.java | Added @Label annotations to enum values for UI display names |
| Orientation.java | Added @Label annotations to enum values for UI display names |
| ExcelTableWriterNodeParameters.java | New file containing declarative node parameter definitions replacing legacy dialog |
| ExcelTableWriterNodeFactory.xml | Removed legacy XML-based node description |
| ExcelTableWriterNodeFactory.java | Updated to implement new dialog and description generation interfaces |
| ExcelTableWriterConfig.java | Changed field visibility from private to package-private for parameter access |
| ExcelEncryptionSettings.java | New reusable parameter widget for Excel encryption configuration |
| ExcelTableWriterNodeParametersTest.java | New test file with snapshot tests and dynamic update validation |
| Test snapshot files | Generated test snapshots for parameter structure validation |
| MANIFEST.MF | Added testing dependency for UI parameter testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tom-mi
force-pushed
the
enh/UIEXT-3109-webui-migration-excel-table-writer
branch
from
7ad3428 to
744b24e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...i3/src/org/knime/ext/poi3/node/io/filehandling/excel/writer/ExcelTableWriterNodeFactory.java
Show resolved
Hide resolved
...nime.ext.poi3/src/org/knime/ext/poi3/node/io/filehandling/excel/ExcelEncryptionSettings.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tom-mi
force-pushed
the
enh/UIEXT-3109-webui-migration-excel-table-writer
branch
from
fa7efc6 to
3f7a02e
Compare
UIEXT-3109 (WebUI-Migration Excel Table Writer)
tom-mi
force-pushed
the
enh/UIEXT-3109-webui-migration-excel-table-writer
branch
from
3f7a02e to
49464ad
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
UIEXT-3109 (WebUI-Migration Excel Table Writer)