-
Notifications
You must be signed in to change notification settings - Fork 0
Todo/nxt 4173 tokenise workflow toolbar #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Todo/nxt 4173 tokenise workflow toolbar #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the workflow toolbar to use tokenized design system components, replacing custom toolbar buttons with standardized KDS components and design tokens. The changes involve refactoring button implementations, updating styling to use KDS design tokens, and consolidating button component logic.
- Replaces custom
ToolbarButtonandToolbarShortcutButtoncomponents with KDSButtoncomponent - Updates all color, spacing, and sizing values to use KDS design tokens
- Introduces new
SaveButtoncomponent to handle the save functionality with submenu
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| WorkflowPage.vue | Updates toolbar styling to use KDS spacing and border tokens |
| ZoomMenu.vue | Replaces hard-coded values with KDS tokens for colors, spacing, and dimensions |
| WorkflowToolbar.vue | Major refactor replacing custom toolbar buttons with KDS Button components and restructuring button configuration |
| WorkflowBreadcrumb.vue | Updates breadcrumb styling with KDS tokens and replaces ToolbarButton with KDS Button |
| ToolbarShortcutButton.vue | Removed - functionality replaced by KDS Button and new SaveButton component |
| SaveButton.vue | New component handling save functionality with submenu, replacing part of ToolbarShortcutButton |
| ToolbarButton.vue | Removed - replaced by KDS Button component |
| ActionBreadcrumb.vue | Updates breadcrumb styling to use KDS tokens |
| mixins.css | Adds new mixin for KDS medium icon sizing |
| fonts.css | Adds Roboto 500 weight font imports needed for KDS typography |
| package.json | Downgrades kds-components and kds-styles package versions |
Files not reviewed (1)
- org.knime.ui.js/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| border-radius: 0 var(--kds-border-radius-container-0-37x) | ||
| var(--kds-border-radius-container-0-37x) 0; | ||
| border-radius: 0 | ||
| var( | ||
| --kds-legacy-button-border-radius, | ||
| var(--kds-border-radius-container-0-37x) | ||
| ) | ||
| var( | ||
| --kds-legacy-button-border-radius, | ||
| var(--kds-border-radius-container-0-37x) | ||
| ) | ||
| 0; |
Copilot
AI
Dec 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The border-radius property is defined twice consecutively (lines 149-150 and 151-160). The second declaration will override the first. Remove the first declaration if the second (with legacy fallback) is the intended styling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- org.knime.ui.js/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
005360b to
43ff241
Compare
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
No description provided.