fix: add radix to parseInt - #1112
Conversation
|
Someone is attempting to deploy a commit to the Karan Mani Tripathi 's projects Team on Vercel. A member of the Team first needs to authorize it. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
github-actions
Bot
added
gssoc'26
|
We are closing this pr as it has no linking issue to it. If your is actually related to a isssue assigned to u then create a new pr and link the issue in discription. |
codeant-ai
Bot
added
the
size:M
github-actions
Bot
added
the
merge-conflict
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe PR adds global and modal-level reduced-motion handling, changing reply auto-scroll behavior accordingly. It also updates both doubt action handlers to parse route IDs explicitly as base-10 integers. ChangesReduced-motion support
Doubt ID parsing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
size/s
size/m
and removed
size:M
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| const { action, content, subject, imageUrl, userName, replyId } = await req.json(); | ||
| const { id } = await params; | ||
| const doubtId = parseInt(id); | ||
| const doubtId = parseInt(id, 10); |
There was a problem hiding this comment.
Suggestion: The route parameter is parsed with parseInt, which accepts numeric prefixes such as 5xyz or 5.9 and silently treats them as doubt ID 5. This allows malformed PATCH requests to perform like, solve, or edit operations on an unintended doubt. Validate that the entire parameter is a canonical decimal integer before querying. [api mismatch]
Severity Level: Major ⚠️
- ❌ Malformed PATCH URLs can operate on another doubt.
- ⚠️ Like operations lack ownership checks at route lines 32-65.
- ⚠️ Edit and solve target the coerced doubt after authorization checks.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** app/api/doubts/action/[id]/route.ts
**Line:** 14:14
**Comment:**
*Api Mismatch: The route parameter is parsed with `parseInt`, which accepts numeric prefixes such as `5xyz` or `5.9` and silently treats them as doubt ID `5`. This allows malformed PATCH requests to perform like, solve, or edit operations on an unintended doubt. Validate that the entire parameter is a canonical decimal integer before querying.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix|
|
||
| const { id } = await params; | ||
| const doubtId = parseInt(id); | ||
| const doubtId = parseInt(id, 10); |
There was a problem hiding this comment.
Suggestion: The DELETE handler now passes the result of parseInt directly to the database without checking for NaN. A nonnumeric route such as /api/doubts/action/abc reaches the query with an invalid ID and can produce a database error returned as HTTP 500 instead of the expected client validation response; values such as 5xyz are also silently treated as ID 5. Reject invalid or non-canonical identifiers before querying. [type error]
Severity Level: Critical 🚨
- ❌ Invalid DELETE identifiers can produce HTTP 500 errors.
- ❌ Numeric-prefix identifiers can delete unintended authorized doubts.
- ⚠️ Frontend doubt deletion uses this route from `DoubtCard.tsx:71`.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** app/api/doubts/action/[id]/route.ts
**Line:** 145:145
**Comment:**
*Type Error: The DELETE handler now passes the result of `parseInt` directly to the database without checking for `NaN`. A nonnumeric route such as `/api/doubts/action/abc` reaches the query with an invalid ID and can produce a database error returned as HTTP 500 instead of the expected client validation response; values such as `5xyz` are also silently treated as ID `5`. Reject invalid or non-canonical identifiers before querying.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
1 participant
CodeAnt-AI Description
Respect reduced-motion preferences and parse doubt IDs consistently
What Changed
Impact
✅ Fewer motion effects for accessibility✅ Less disruptive reply scrolling✅ More reliable doubt ID handling💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
Accessibility
Bug Fixes