Skip to content

fix: wrap doubt like toggle in transaction with floor guard (#472) #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vedant7007 wants to merge 1 commit into from
Closed

fix: wrap doubt like toggle in transaction with floor guard (#472) #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 43 additions & 28 deletions src/app/api/doubts/action/[id]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,38 +52,53 @@ export async function PATCH(req: Request, { params }: { params: Promise<{ id: st
if (!email) {
return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
}

const secureUserIdentifier = email;

// Check if already liked
const existingLike = await db.select()
.from(likesTable)
.where(and(eq(likesTable.userName, secureUserIdentifier), eq(likesTable.doubtId, doubtId)))
.limit(1);
const result = await db.transaction(async (tx) => {
const locked = await tx.execute(
sql`SELECT ${doubtsTable.id} FROM ${doubtsTable} WHERE ${doubtsTable.id} = ${doubtId} FOR UPDATE`
);

if (existingLike.length > 0) {
await db.delete(likesTable)
.where(and(eq(likesTable.userName, secureUserIdentifier), eq(likesTable.doubtId, doubtId)));

const updated = await db.update(doubtsTable)
.set({ likes: sql`${doubtsTable.likes} - 1` })
.where(eq(doubtsTable.id, doubtId))
.returning();

return NextResponse.json({ ...updated[0], hasLiked: false });
} else {
await db.insert(likesTable).values({
userName: secureUserIdentifier,
doubtId
});

const updated = await db.update(doubtsTable)
.set({ likes: sql`${doubtsTable.likes} + 1` })
.where(eq(doubtsTable.id, doubtId))
.returning();

return NextResponse.json({ ...updated[0], hasLiked: true });
if (!locked.rows.length) {
return null;
}

const existingLike = await tx.select()
.from(likesTable)
.where(and(eq(likesTable.userName, secureUserIdentifier), eq(likesTable.doubtId, doubtId)))
.limit(1);

if (existingLike.length > 0) {
await tx.delete(likesTable)
.where(and(eq(likesTable.userName, secureUserIdentifier), eq(likesTable.doubtId, doubtId)));

const updated = await tx.update(doubtsTable)
.set({ likes: sql`GREATEST(${doubtsTable.likes} - 1, 0)` })
.where(eq(doubtsTable.id, doubtId))
.returning();

return { ...updated[0], hasLiked: false };
} else {
await tx.insert(likesTable).values({
userName: secureUserIdentifier,
doubtId
});

const updated = await tx.update(doubtsTable)
.set({ likes: sql`${doubtsTable.likes} + 1` })
.where(eq(doubtsTable.id, doubtId))
.returning();

return { ...updated[0], hasLiked: true };
}
});

if (!result) {
return NextResponse.json({ error: "Doubt not found" }, { status: 404 });
}

return NextResponse.json(result);
}

if (action === "solve") {
Expand Down
Loading