Skip to content

fix: add inline validation message for empty subject field #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knoxiboy merged 3 commits into from
Jun 9, 2026
Merged

fix: add inline validation message for empty subject field #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79b5d98
fix: add inline validation message for empty subject field
muditd27 Jun 3, 2026
bf08aea
Merge remote-tracking branch 'upstream/main' into muditd27/form-valid…
muditd27 Jun 8, 2026
7cd30dc
fix: resolve TypeScript error in replies route and add framer-motion
muditd27 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/app/api/replies/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,18 @@ export async function GET(req: Request) {
}

if (doubt.type === 'teacher') {
const [membership] = await db
.select()
.from(membershipsTable)
.where(
and(
eq(membershipsTable.userEmail, email),
eq(membershipsTable.classroomId, doubt.classroomId!)
)
);
if (!doubt.classroomId) {
return errorResponse("Access denied", 403);
}
const [membership] = await db
.select()
.from(membershipsTable)
.where(
and(
eq(membershipsTable.userEmail, email!),
eq(membershipsTable.classroomId, doubt.classroomId)
)
);

const isTeacher = membership ? canTeach(membership.role) : false;
const isOwner = doubt.userEmail === email;
Expand Down
3 changes: 3 additions & 0 deletions src/components/AskDoubt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ export default function AskDoubt({ defaultSubject = "", isOpen, onClose, onSucce
className="w-full bg-slate-100 dark:bg-white/5 border border-slate-200 dark:border-white/10 rounded-2xl p-4 text-slate-900 dark:text-white focus:outline-none focus:border-blue-500/50 font-bold text-sm"
required
/>
{subjectWasEdited && !subject.trim() && (
<p className="text-red-400 text-xs font-semibold px-1 mt-1">Subject is required.</p>
)}
{suggestedSubject && (
<div className="flex items-center gap-2 px-1 text-[10px] font-bold uppercase tracking-widest text-blue-300">
<Sparkles className="w-3 h-3" />
Expand Down
Loading