RscTables-tool translation and simple ui settings. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate buttons are pulled up and scrollbar is added, and all translatable messagebox and area are translated to English language.
TableGenerator.cpp
stevewgr
requested changes
Oct 21, 2022
There was a problem hiding this comment.
Awesome! Very helpful, @SeniourMarquies.
Please fix the encoding though, otherwise we can't review this.
Comment on lines
77
to
81
| this->ParseLine(szLine, iOffset, iVal, dwVal, dfVal, | ||
| szText); // �����ϸ� 0, �߰��ؾ��ϰ� ���̸� -1 �߰��� �ʿ� ��� ���̸�.. -2 ���� | ||
| szText); // �����ϸ� 0, �߰��ؾ��ϰ� ���̸� -1 �߰��� �ʿ� ���� ���̸�.. -2 ���� | ||
|
|
||
| if (iSuccess > 0) { | ||
| if (i == 0) // ù��� �����̴�.. | ||
| if (i == 0) // ù���� �����̴�.. |
There was a problem hiding this comment.
Your text editor broke encoding.
There was a problem hiding this comment.
Fixed encoding, removed unnecessary comments, and adjusted simple UI resolution. Please review both the UIE and RscTables PRs
stevewgr
changed the base branch from
RscTables-Tool-trasnlation-and-ui-changes
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate buttons are pulled up and scrollbar is added, and all translatable messagebox and area are translated to English language.