Remove unused grass (seed) implementation from both client and N3ME. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In N3ME, this feature is referred to as "seed," while in the client, it is called "grass". This functionality is unused in the official release and does not justify ongoing maintenance. Reviewing the code and files in Misc/grass, which haven't been modified since the game's release, confirms it is unused. The original developer appears to have intended for grass/seeds to be part of terrain data (gtd). However, in the official implementation, they are added to the opd file as shapes with simple textures and without collision, making the grass implementation redundant.
stevewgr
requested review from
srmeier,
ForcePower,
UTengine,
xGuTeK and
JanekCode
|
For the record, build is passing: https://github.com/ko4life-net/ko/actions/runs/11809857978 but I'll still wait to hear your thoughts / review before merging. |
xGuTeK
approved these changes
Nov 13, 2024
srmeier
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes an unused grass (or seed) implementation from both the client and N3ME. This feature, referenced as "seed" in N3ME and "grass" in the client, is not utilized in the official game, making it unnecessary to maintain.
Details
Misc/grassfiles, which have remained unchanged since the game's initial release. It also seems like a work-in-progress implementation.Rationale
Given its lack of use and maintenance, removing this redundant implementation reduces complexity and potential confusion in the codebase. This change helps streamline development by eliminating an unused feature that provides no functional benefit.