fix(desktop): gate macOS title_bar_style behind cfg for Linux builds#2031
Open
jrtorrez31337 wants to merge 1 commit intokoala73:mainfrom
Open
fix(desktop): gate macOS title_bar_style behind cfg for Linux builds#2031jrtorrez31337 wants to merge 1 commit intokoala73:mainfrom
jrtorrez31337 wants to merge 1 commit intokoala73:mainfrom
Conversation
|
@jrtorrez31337 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Saw issue #802 (unable to add API keys on Linux) and started looking into the Linux desktop build situation. The desktop app doesn't compile on Linux because
WebviewWindowBuilder::title_bar_style()is a macOS-only Tauri API. Two call sites inmain.rsuse it unconditionally.Can only verify Linux for now — don't have a macOS or Windows build environment to confirm those are unaffected.
Changes
title_bar_style(TitleBarStyle::Overlay)is only called behind#[cfg(target_os = "macos")]#[allow(unused_mut)]to suppress the resulting warning on non-macOS targets where themutbinding is only needed for the cfg-gated reassignmentTest plan
cargo tauri buildsucceeds on Linux (verified in Ubuntu 24.04 container)