Skip to content

fix(redis): use POST body for setCachedJson to avoid ECONNRESET with large payloads #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bighaoZQH wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −3
Open

fix(redis): use POST body for setCachedJson to avoid ECONNRESET with large payloads #2524

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4c0aca
fix(redis): use pipeline body for setCachedJson to avoid URL length l…
bighaoZQH Mar 29, 2026
d94bb54
fix(redis): use POST body for setCachedJson to avoid URL length limit
bighaoZQH Mar 29, 2026
ed9d1bd
fix: update timeout and add resp.ok check for setCachedJson
bighaoZQH Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions server/_shared/redis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,18 @@ export async function setCachedJson(key: string, value: unknown, ttlSeconds: num
if (!url || !token) return;
try {
// Atomic SET with EX — single call avoids race between SET and EXPIRE (C-3 fix)
await fetch(`${url}/set/${encodeURIComponent(prefixKey(key))}/${encodeURIComponent(JSON.stringify(value))}/EX/${ttlSeconds}`, {
const resp = await fetch(`${url}/`, {
method: 'POST',
headers: { Authorization: `Bearer ${token}` },
signal: AbortSignal.timeout(REDIS_OP_TIMEOUT_MS),
headers: {
Authorization: `Bearer ${token}`,
'Content-Type': 'application/json',
},
body: JSON.stringify(['SET', prefixKey(key), JSON.stringify(value), 'EX', String(ttlSeconds)]),
signal: AbortSignal.timeout(REDIS_PIPELINE_TIMEOUT_MS),
});
if (!resp.ok) {
console.warn(`[redis] setCachedJson HTTP ${resp.status}`);
}
} catch (err) {
console.warn('[redis] setCachedJson failed:', errMsg(err));
}
Expand Down