fix(map): disable imagery footprint stroke to prevent Intel GPU shader crash#2529
fix(map): disable imagery footprint stroke to prevent Intel GPU shader crash#2529
Conversation
…t Intel GPU shader crash deck.gl PolygonLayer with getLineColor spawns an internal PathLayer stroke sublayer whose fragment shader fails to compile on Intel integrated GPUs (i11-series, Windows 11). Setting stroked: false prevents the satellite-imagery-layer-stroke-fragment shader from being compiled. Fixes #2518
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Greptile SummaryThis is a targeted one-line fix to Key changes:
Trade-off: The visible blue outline ( Confidence Score: 5/5Safe to merge — minimal, correct fix with no logic regressions; intentional visual trade-off is well-documented The change is two lines removed, one line added. It correctly uses deck.gl's documented stroked: false flag to prevent sublayer creation, directly addressing the root cause of the Intel GPU crash. No logic changes, no type errors, and the test plan covers the relevant regression surfaces. No files require special attention Important Files Changed
Sequence DiagramsequenceDiagram
participant App as DeckGLMap
participant PL as PolygonLayer (deck.gl)
participant SL as PathLayer (stroke sublayer)
participant GPU as WebGL / Intel GPU
Note over App,GPU: Before this PR
App->>PL: new PolygonLayer({ getLineColor, lineWidthMinPixels })
PL->>SL: auto-spawns internal stroke sublayer
SL->>GPU: compile satellite-imagery-layer-stroke-fragment shader
GPU-->>SL: ❌ shader compilation failure (Intel i11 / Win11)
Note over App,GPU: After this PR
App->>PL: new PolygonLayer({ stroked: false })
PL-->>SL: no stroke sublayer created
PL->>GPU: compile fill shader only
GPU-->>PL: ✅ renders translucent fill correctly
Reviews (1): Last reviewed commit: "fix(map): disable PolygonLayer stroke on..." | Re-trigger Greptile |
Summary
PolygonLayerwithgetLineColorcauses deck.gl to spawn an internalPathLayerstroke sublayersatellite-imagery-layer-stroke-fragment) fails to compile on Intel integrated GPUs (i11-series, Windows 11), crashing the orbital surveillance / satellite imagery layerstroked: false— removes the stroke sublayer entirely, eliminating the shader compilation failureFixes #2518
Test plan
npm run typecheckpasses