Skip to content

fix(map): disable imagery footprint stroke to prevent Intel GPU shader crash#2529

Merged
koala73 merged 1 commit intomainfrom
fix/intel-gpu-polygon-stroke-shader
Mar 29, 2026
Merged

fix(map): disable imagery footprint stroke to prevent Intel GPU shader crash#2529
koala73 merged 1 commit intomainfrom
fix/intel-gpu-polygon-stroke-shader

Conversation

@koala73
Copy link
Copy Markdown
Owner

@koala73 koala73 commented Mar 29, 2026

Summary

  • PolygonLayer with getLineColor causes deck.gl to spawn an internal PathLayer stroke sublayer
  • Its fragment shader (satellite-imagery-layer-stroke-fragment) fails to compile on Intel integrated GPUs (i11-series, Windows 11), crashing the orbital surveillance / satellite imagery layer
  • Fix: set stroked: false — removes the stroke sublayer entirely, eliminating the shader compilation failure

Fixes #2518

Test plan

  • Verify satellite imagery footprints still render (translucent fill) on all GPU types
  • Confirm no WebGL errors in console on Intel GPU (Windows)
  • npm run typecheck passes

…t Intel GPU shader crash

deck.gl PolygonLayer with getLineColor spawns an internal PathLayer stroke
sublayer whose fragment shader fails to compile on Intel integrated GPUs
(i11-series, Windows 11). Setting stroked: false prevents the
satellite-imagery-layer-stroke-fragment shader from being compiled.

Fixes #2518
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
worldmonitor Ignored Ignored Mar 29, 2026 7:15pm

Request Review

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 29, 2026

Greptile Summary

This is a targeted one-line fix to createImageryFootprintLayer in DeckGLMap.ts that prevents a WebGL shader compilation crash on Intel integrated GPUs by disabling the PolygonLayer stroke sublayer entirely.

Key changes:

  • Removes getLineColor and lineWidthMinPixels from the satellite imagery footprint PolygonLayer
  • Adds stroked: false, which prevents deck.gl from spawning the internal PathLayer stroke sublayer whose fragment shader was failing to compile on Intel i11-series GPUs (Windows 11)
  • The translucent fill ([0, 180, 255, 40]) is preserved — footprint polygons remain visible

Trade-off: The visible blue outline ([0, 180, 255, 180]) around imagery footprints is intentionally sacrificed in exchange for cross-GPU compatibility. This is a reasonable trade-off given that the stroke sublayer was crashing the entire layer on affected hardware.

Confidence Score: 5/5

Safe to merge — minimal, correct fix with no logic regressions; intentional visual trade-off is well-documented

The change is two lines removed, one line added. It correctly uses deck.gl's documented stroked: false flag to prevent sublayer creation, directly addressing the root cause of the Intel GPU crash. No logic changes, no type errors, and the test plan covers the relevant regression surfaces.

No files require special attention

Important Files Changed

Filename Overview
src/components/DeckGLMap.ts Removes getLineColor and lineWidthMinPixels from createImageryFootprintLayer, replacing them with stroked: false to prevent the internal PathLayer sublayer that causes Intel GPU shader crashes

Sequence Diagram

sequenceDiagram
    participant App as DeckGLMap
    participant PL as PolygonLayer (deck.gl)
    participant SL as PathLayer (stroke sublayer)
    participant GPU as WebGL / Intel GPU

    Note over App,GPU: Before this PR
    App->>PL: new PolygonLayer({ getLineColor, lineWidthMinPixels })
    PL->>SL: auto-spawns internal stroke sublayer
    SL->>GPU: compile satellite-imagery-layer-stroke-fragment shader
    GPU-->>SL: ❌ shader compilation failure (Intel i11 / Win11)

    Note over App,GPU: After this PR
    App->>PL: new PolygonLayer({ stroked: false })
    PL-->>SL: no stroke sublayer created
    PL->>GPU: compile fill shader only
    GPU-->>PL: ✅ renders translucent fill correctly
Loading

Reviews (1): Last reviewed commit: "fix(map): disable PolygonLayer stroke on..." | Re-trigger Greptile

@koala73 koala73 merged commit b84c716 into main Mar 29, 2026
8 checks passed
@koala73 koala73 deleted the fix/intel-gpu-polygon-stroke-shader branch March 29, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: orbital surveillance crashing

1 participant