-
Notifications
You must be signed in to change notification settings - Fork 7.7k
feat(quiet-hours): add quiet hours scheduling to notification alert rules #2615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
350af65
feat(quiet-hours): add quiet hours scheduling to notification alert r…
koala73 de6a4e7
fix(quiet-hours): time-driven drain, anyDelivered guard, dedup on hel…
koala73 044beeb
fix(quiet-hours): flush held events when settings change away from ba…
koala73 920894f
fix(quiet-hours): respect rule channels in flush_quiet_held path
koala73 dd5145b
fix(quiet-hours): use public getByEnabled query in flush path
koala73 6c8c3bb
fix(quiet-hours): guard against null allowedChannels in flush path
koala73 171bbb3
fix(quiet-hours): add QUIET_HOURS_BATCH_ENABLED guard, IANA timezone …
koala73 44099e2
fix(quiet-hours): hide batch_on_wake UI option when VITE_QUIET_HOURS_…
koala73 bac4b44
test(quiet-hours): add rollout-flag and timezone-validation regressio…
koala73 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validateQuietHoursArgsvalidates the numeric range ofquietHoursStart/quietHoursEndbut accepts any string forquietHoursTimezone. An invalid timezone (e.g."America/Fake") is persisted to the database, and at enforcement timetoLocalHourcatches theRangeErrorand returns-1, causingisInQuietHoursto always returnfalse. Quiet hours silently never fire.Consider validating the timezone at write time:
Note:
validateQuietHoursArgsis called in bothsetQuietHoursandsetQuietHoursForUser; the same fix covers both paths.