Skip to content

fix(convex): rename identity-signing to identitySigning#2630

Merged
koala73 merged 1 commit intomainfrom
fix/convex-identity-signing-rename
Apr 2, 2026
Merged

fix(convex): rename identity-signing to identitySigning#2630
koala73 merged 1 commit intomainfrom
fix/convex-identity-signing-rename

Conversation

@koala73
Copy link
Copy Markdown
Owner

@koala73 koala73 commented Apr 2, 2026

Convex module paths cannot contain hyphens — only alphanumeric characters, underscores, or periods. The convex/lib/identity-signing.ts file added in #2024 blocked deployment with:

InvalidConfig: lib/identity-signing.js is not a valid path to a Convex module.

Changes:

  • Rename convex/lib/identity-signing.tsconvex/lib/identitySigning.ts
  • Update imports in convex/payments/checkout.ts and convex/payments/subscriptionHelpers.ts

Convex has been deployed successfully with this fix.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
worldmonitor Ignored Ignored Apr 2, 2026 8:39pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 2, 2026

Greptile Summary

This PR fixes a Convex deployment blocker by renaming convex/lib/identity-signing.ts to convex/lib/identitySigning.ts (Convex module paths cannot contain hyphens) and updating the two import sites in checkout.ts and subscriptionHelpers.ts. The rename is 100% content-identical and all import paths are correctly updated.

Confidence Score: 5/5

Safe to merge — purely a rename fix with no logic changes and all import paths correctly updated.

All three changed files are straightforward: an identical file rename and two single-line import updates. The only finding is a P2 cosmetic stale log prefix string, which has no impact on runtime behavior.

No files require special attention.

Important Files Changed

Filename Overview
convex/lib/identitySigning.ts File renamed from identity-signing.ts with identical content; one minor cosmetic stale prefix in error message string.
convex/payments/checkout.ts Import path updated from ../lib/identity-signing to ../lib/identitySigning; no other changes.
convex/payments/subscriptionHelpers.ts Import path updated from ../lib/identity-signing to ../lib/identitySigning; no other changes.

Sequence Diagram

sequenceDiagram
    participant Client
    participant checkout.ts
    participant identitySigning.ts
    participant DodoPayments
    participant subscriptionHelpers.ts

    Client->>checkout.ts: createCheckout(productId, returnUrl, ...)
    checkout.ts->>checkout.ts: requireUserId(ctx)
    checkout.ts->>identitySigning.ts: signUserId(userId)
    identitySigning.ts-->>checkout.ts: HMAC-SHA256 hex signature
    checkout.ts->>DodoPayments: checkout({ metadata: { wm_user_id, wm_user_id_sig } })
    DodoPayments-->>Client: checkout_url

    Note over DodoPayments,subscriptionHelpers.ts: Webhook callback
    DodoPayments->>subscriptionHelpers.ts: processWebhookEvent(payload)
    subscriptionHelpers.ts->>identitySigning.ts: verifyUserId(wm_user_id, wm_user_id_sig)
    identitySigning.ts-->>subscriptionHelpers.ts: true / false
    subscriptionHelpers.ts->>subscriptionHelpers.ts: upsertEntitlements(userId, planKey, ...)
Loading

Comments Outside Diff (1)

  1. convex/lib/identitySigning.ts, line 17 (link)

    P2 Stale module name in error message prefix

    The error message string still references [identity-signing] (the old filename). This is cosmetic and has no functional impact, but keeping it consistent with the new module name avoids confusion when reading logs.

Reviews (1): Last reviewed commit: "fix(convex): rename identity-signing to ..." | Re-trigger Greptile

@koala73 koala73 merged commit b482a7f into main Apr 2, 2026
7 checks passed
@koala73 koala73 deleted the fix/convex-identity-signing-rename branch April 2, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant