Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TimeField component #529

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xbinaryx
Copy link

This PR adds a new TimeField component.

Closes #317

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for kobalte ready!

Name Link
🔨 Latest commit 50941a9
🔍 Latest deploy log https://app.netlify.com/sites/kobalte/deploys/673c006910349a00088b9b21
😎 Deploy Preview https://deploy-preview-529--kobalte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@xbinaryx
Copy link
Author

xbinaryx commented Nov 17, 2024

I dont see how the failed tests are related to this PR. Looks like a flaky test. It passes now.

Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, mostly looks good!

Small changes required;

The time zone segment shouldn't be interactive since we can change it.
image
AM should be the last highlighted item when you move right.

For arrow interaction the min and max should probably not inc/decrement when out of bounds. The warning should only appear if an invalid time is manually typed.
image

Placeholder doesn't seem to work (W11 FF 132.0.2):
image

Lastly the hidden input should follow changes to it, this is done to allow browser form autofill and cache. More info below.

@xbinaryx
Copy link
Author

xbinaryx commented Nov 18, 2024

Hey Jeremy, thanks for the review!

Placeholder doesn't seem to work (W11 FF 132.0.2):

When you increment the hour, it doesn’t start at 9?

@jer3m01
Copy link
Member

jer3m01 commented Nov 18, 2024

When you increment the hour, it doesn’t start at 9?

Yeah it does, I still think it would be good to also make it display the placeholder in gray (and become a value on first interact).

Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] TimeField
2 participants