Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebsocketProxy.Director optional function to forward additional headers #11

Merged
merged 2 commits into from
Mar 29, 2017

Conversation

emidoots
Copy link

Useful in situations where a WebSocket HTTP server that is being proxied to
requires custom headers, and also should fix issues like #9

…eaders

Useful in situations where a WebSocket HTTP server that is being proxied to
requires custom headers, and also should fix issues like koding#9
@emidoots
Copy link
Author

It looks like this project is built with a (very) old version of Go on CI, which doesn't have sync.Pool, hence the error:

../../gorilla/websocket/compression.go:95: undefined: sync.Pool

@cihangir
Copy link
Contributor

You can update the version here

@emidoots
Copy link
Author

Thanks! I've added a commit to fix Travis directly to this PR. It looks like Go 1.5 is the minimum required version, because of tls.Config.GetCertificate being in use.

@@ -1,2 +1,2 @@
language: go
go: 1.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it go1.8?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rjeczalik rjeczalik merged commit 7338eea into koding:master Mar 29, 2017
@rjeczalik
Copy link
Member

Thanks @slimsag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants