Update Exercises and CI Configuration #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzehner
reviewed
Feb 25, 2025
Comment on lines
+74
to
84
| using ExecSpace = Kokkos::Serial; | ||
| // using ExecSpace = Kokkos::Threads; | ||
| // using ExecSpace = Kokkos::OpenMP; | ||
| using ExecSpace = Kokkos::Cuda; | ||
| // using ExecSpace = Kokkos::Cuda; | ||
| // using ExecSpace = Kokkos::HIP; | ||
|
|
||
| // using MemSpace = Kokkos::HostSpace; | ||
| using MemSpace = Kokkos::HostSpace; | ||
| // using MemSpace = Kokkos::OpenMP; | ||
| using MemSpace = Kokkos::CudaSpace; | ||
| // using MemSpace = Kokkos::CudaSpace; | ||
| // using MemSpace = Kokkos::HIPSpace; | ||
| // using MemSpace = Kokkos::CudaUVMSpace; |
There was a problem hiding this comment.
I don't think we should let users manipulate "concrete" execution spaces, as this is not portable, unless we have a really good reason. I saw many tutorial attendants having troubles with this.
pzehner
reviewed
Feb 25, 2025
|
@AdRi1t - this looks good. Could you please make this ready for review? |
Signed-off-by: Adrien Taberner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercises
simd_warpexercise, as the API no longer existsMC_DartSamplerto run without arguments for CI compatibilityexercise_subviewto ensure it compiles in CICI Configuration Updates
Scripts/ci-run-solutions.shmatrix.backend