Skip to content

Update tutorial to get the latest release of Kokkos #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2024
Merged

Update tutorial to get the latest release of Kokkos #92

merged 2 commits into from
Jun 23, 2024

Conversation

cedricchevalier19
Copy link
Member

Should be merged after #91 .

@cedricchevalier19 cedricchevalier19 mentioned this pull request Jun 5, 2024
Open
4 tasks
JBludau
JBludau reviewed Jun 13, 2024
View reviewed changes
@cedricchevalier19
Update to Kokkos 4.3.01
ba14127
@cedricchevalier19
Fix missing include for scatter_view
b82fa68 
Kokkos hopefully does not export iostream anymore.
@cedricchevalier19 cedricchevalier19 self-assigned this Jun 14, 2024
@cedricchevalier19 cedricchevalier19 marked this pull request as ready for review June 14, 2024 12:55
JBludau
JBludau reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be fine with splitting it into two, one bumping the version, the other fixing the includes? Just to have a clean history in the repo

@cedricchevalier19
Copy link
Member Author

Would you be fine with splitting it into two, one bumping the version, the other fixing the includes? Just to have a clean history in the repo

The include fix can go first but I do not think it will make a lot of differences on the history side.

JBludau
JBludau approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is fine. But I would love if the title would reflect the fact that missing includes were fixed, too. But no hard feelings about this

@cedricchevalier19 cedricchevalier19 merged commit c68a572 into kokkos:main Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@masterleinad masterleinad masterleinad approved these changes

@aprokop aprokop aprokop approved these changes

@JBludau JBludau JBludau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cedricchevalier19 cedricchevalier19

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cedricchevalier19 @masterleinad @aprokop @JBludau