tightened up tests for throttle-promises

kolodny · Jun 12, 2015 · 6343113 · 6343113
1 parent 34dc2ca
commit 6343113
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/throttle-promises/test.js b/throttle-promises/test.js
@@ -6,19 +6,20 @@ describe('throttle-promises', function() {
     var passed = true;
     var limit = 5;
     var currentlyExecuting = 0;
-    var maxCurrentlyExecuting = 0;
+    var currentlyExecutingHistory = [currentlyExecuting];
     var nextValue = 0;
     var asyncFactory = function() {
       return new Promise(function(resolve) {
         var resolveWith = nextValue++;
         currentlyExecuting++;
-        maxCurrentlyExecuting = Math.max(maxCurrentlyExecuting, currentlyExecuting);
+        currentlyExecutingHistory.push(currentlyExecuting);
         if (currentlyExecuting > limit) {
           passed = false;
         }
         setTimeout(function() {
           resolve(resolveWith + '!');
           currentlyExecuting--;
+          currentlyExecutingHistory.push(currentlyExecuting);
         }, Math.random() * 100);
       });
     };
@@ -32,9 +33,13 @@ describe('throttle-promises', function() {
       var expectedResults = Array(101).join('.').split('').map(function(dot, index) {
         return index + '!';
       });
+      var expectedHistory = Array(202).join('.').split('').map(function(dot, index) {
+        return index < 5 ? index : index >= 200 - 5 ? 200 - index : index % 2 ? 5 : 4;
+      });
+
       assert(passed, 'more than ' + limit + ' promises ran in parallel');
-      assert.equal(maxCurrentlyExecuting, limit);
       assert.deepEqual(results, expectedResults);
+      assert.deepEqual(currentlyExecutingHistory, expectedHistory);
       done();
     });