Fix: Remove conflicting global variable redefinitions (#1168) - #1186
Open
desireddymohithreddy0925 wants to merge 12 commits into
Open
Fix: Remove conflicting global variable redefinitions (#1168)#1186desireddymohithreddy0925 wants to merge 12 commits into
desireddymohithreddy0925 wants to merge 12 commits into
Conversation
|
Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@desireddymohithreddy0925 kindly resolve the merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug reported in #1168 where validation data was being lost due to conflicting global variable redefinitions. The global variables
VALID_LEVELS,VALID_INTERESTS, andVALID_TIME_AVAILABILITYwere fully defined at the top ofsrc/utils/recommender.py, but were mistakenly redefined at the bottom of the file with incomplete lists. This caused valid areas of interest, such as "mobile" and "machine learning/ai", to be dropped during backend validation. I have removed the redundant, incorrect definitions at the bottom of the file to ensure the full valid sets are retained.Related Issue
Closes #1168
Type of Change
data/projects.jsonWhat Was Changed
src/utils/recommender.pyVALID_LEVELS,VALID_INTERESTS, andVALID_TIME_AVAILABILITYwith incomplete lists.How to Test This PR
git checkout fix/issue-1168-duplicate-globalspip install -r requirements.txtpython app.pypython tests/test_basic.py(orpytest tests/test_basic.py)Expected test output:
Test Results
Self-Review Checklist
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
None