test : add comprehensive unit tests for url_validator edge cases - #1313
Open
tmdeveloper007 wants to merge 1 commit into
Open
test : add comprehensive unit tests for url_validator edge cases#1313tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Created
tests/test_url_validator.pywith 40 unit tests covering all public functions insrc/utils/url_validator.py:is_valid_url: 20 tests (valid URLs with https/http/ports/paths/query/fragments/localhost, invalid None/empty/whitespace/non-string/ftp/mailto/bare-domain/file/relative-path)parse_resource: 9 tests (labeled format, bare URL format, None/empty/non-string/whitespace inputs, edge cases for split marker)validate_resource: 4 tests (valid labeled, invalid labeled, bare valid, bare invalid)validate_resources: 5 tests (valid list, mixed list, empty list, non-list inputs)Changes Made
tests/test_url_validator.pywith 268 lines of pytest-style testsImpact it Made
Closes #1309
Note: Please assign this PR to the
tmdeveloper007account.