fix : prevented duplicate entries in _partition_lists case-insensitive comparison - #1341
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : prevented duplicate entries in _partition_lists case-insensitive comparison#1341tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
@tmdeveloper007 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Fixed the
_partition_listsfunction insrc/utils/roadmap_comparer.pyto prevent duplicate entries when the same semantic item appears in both lists with different capitalizations.The bug caused items like "Python" (list_a) and "python" (list_b) to appear both in the
overlappinglist AND in theunique_blist, because theunique_bcomprehension only checkedkey not in norm_awithout considering that the key had already been claimed as overlapping.Changes Made
unique_blist comprehension in_partition_liststo exclude keys that have already been added to the overlapping list:Impact it Made
Closes #1336
Note: Please assign this PR to the
tmdeveloper007account.