fix : replaced deprecated datetime.utcnow with timezone-aware alternative in code_review - #1412
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : replaced deprecated datetime.utcnow with timezone-aware alternative in code_review#1412tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
…ive in code_review
|
@tmdeveloper007 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@tmdeveloper007 kindly resolve the merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Replaced all occurrences of the deprecated
datetime.utcnow()withdatetime.now(timezone.utc)insrc/utils/code_review.py.Changes Made
from datetime import datetimetofrom datetime import datetime, timezonein the import statementdatetime.utcnow()withdatetime.now(timezone.utc)in 5 locations across the following methods:submit_codemethod (submitted_at timestamp)start_reviewmethod (review_id generation and started_at timestamp)add_feedback_commentmethod (created_at timestamp)complete_reviewmethod (completed_at timestamp)Impact it Made
datetime.utcnow()Closes #1407.
Note: Please assign this PR to the
tmdeveloper007account.