fix : close unclosed SKILL_SYNONYMS dict and fix parse_skills and parse_skill_entries in recommender - #1489
Open
tmdeveloper007 wants to merge 1 commit into
Open
Conversation
…s, and fix parse_skill_entries return value
|
Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Fixed multiple bugs in
src/utils/recommender.py:Closed unclosed
SKILL_SYNONYMSdict (line 72) — the dict was missing its closing}, causingSyntaxError: '{' was never closedon import. Added}after the last entry ("tf": "tensorflow").Fixed
parse_skill_entriesto return proper entry dicts with "skill" and "proficiency" keys instead of returning raw skill strings.Fixed
parse_skillsto return[entry["skill"] for entry in parse_skill_entries(skills_string)]— the function had no return statement and was returningNone.Removed duplicate
parse_skillsfunction definitions — three definitions existed, only the last one was used.Removed orphaned unreachable code — 36 lines of code with invalid indentation were left over from the original bug.
Changes Made
Impact it Made
SyntaxErrorparse_skillsandparse_skill_entriesnow return correct valuesTests
All related unit tests pass:
test_parse_skillstest_parse_skills_valid_json_arraytest_parse_skills_containing_commastest_parse_skills_duplicate_entriestest_score_single_project_full_matchtest_skill_synonym_matchingCloses #1480
Note
Please assign this PR to the
tmdeveloper007account.