Skip to content

fix : close unclosed SKILL_SYNONYMS dict and fix parse_skills and parse_skill_entries in recommender - #1489

Open
tmdeveloper007 wants to merge 1 commit into
komalharshita:mainfrom
tmdeveloper007:fix/recommender-clean
Open

fix : close unclosed SKILL_SYNONYMS dict and fix parse_skills and parse_skill_entries in recommender#1489
tmdeveloper007 wants to merge 1 commit into
komalharshita:mainfrom
tmdeveloper007:fix/recommender-clean

Conversation

@tmdeveloper007

Copy link
Copy Markdown
Contributor

Summary of What Has Been Done

Fixed multiple bugs in src/utils/recommender.py:

  1. Closed unclosed SKILL_SYNONYMS dict (line 72) — the dict was missing its closing }, causing SyntaxError: '{' was never closed on import. Added } after the last entry ("tf": "tensorflow").

  2. Fixed parse_skill_entries to return proper entry dicts with "skill" and "proficiency" keys instead of returning raw skill strings.

  3. Fixed parse_skills to return [entry["skill"] for entry in parse_skill_entries(skills_string)] — the function had no return statement and was returning None.

  4. Removed duplicate parse_skills function definitions — three definitions existed, only the last one was used.

  5. Removed orphaned unreachable code — 36 lines of code with invalid indentation were left over from the original bug.

Changes Made

  • 1 file changed, 26 insertions, 63 deletions

Impact it Made

  • App can now be imported and started without SyntaxError
  • parse_skills and parse_skill_entries now return correct values
  • Removed dead/duplicate code

Tests

All related unit tests pass:

  • test_parse_skills
  • test_parse_skills_valid_json_array
  • test_parse_skills_containing_commas
  • test_parse_skills_duplicate_entries
  • test_score_single_project_full_match
  • test_skill_synonym_matching

Closes #1480

Note

Please assign this PR to the tmdeveloper007 account.

…s, and fix parse_skill_entries return value
@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc-2026 type:bug Something isn't working labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc-2026 type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix : close unclosed SKILL_SYNONYMS dict and remove duplicate parse_skills in recommender

1 participant