Skip to content

Dev#1

Open
naumov-artem wants to merge 9 commits intomasterfrom
dev
Open

Dev#1
naumov-artem wants to merge 9 commits intomasterfrom
dev

Conversation

@naumov-artem
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@sotnikov-link sotnikov-link left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Объясни, зачем нужно переименовывать картинки?
  2. Напиши человеческие alt атрибуты картинкам.
  3. Основное замечание: блоки расположены не правильно, исправляй в соответствии с мок-апом.
  4. Сообщи Свете, как исправишь, она проверит.

margin: auto;
opacity: 0.2;
display: none;"
></div>
Copy link
Copy Markdown
Member

@sotnikov-link sotnikov-link Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ты смотрел по мок-апу результат? Там расхождения.
2017-03-28 14 37 55

<td style="height: 10px; padding: 0">

</h1>
</td>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это лучше, чем было. Сделал правильно.

@@ -5,6 +5,21 @@
<title>E-mail</title>
</head>
<body style="margin: 0;">
Copy link
Copy Markdown
Member

@sotnikov-link sotnikov-link Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для мок-апа в седьмой строке не хватает css-свойства position — добавь.

Copy link
Copy Markdown
Member

@sotnikov-link sotnikov-link left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Расхождения с мокапом — исправляй.

Copy link
Copy Markdown
Member

@sotnikov-link sotnikov-link left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 Нет мокапа — не с чем сверять.

Copy link
Copy Markdown
Member

@sotnikov-link sotnikov-link left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants