Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cpu limits from tasks #1821

Merged
merged 10 commits into from
Jan 29, 2025
Merged

Remove cpu limits from tasks #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cbfd101
remove cpu limits from step templates
enkeefe00 Jan 13, 2025
0b0dfad
remove CPU limits from individual steps
enkeefe00 Jan 13, 2025
421c5bb
remove CPU limits from trusted artifacts
enkeefe00 Jan 15, 2025
cb926af
Merge branch 'main' into remove-cpu-limits-from-tasks
enkeefe00 Jan 15, 2025
f795b10
Merge branch 'main' into remove-cpu-limits-from-tasks
enkeefe00 Jan 16, 2025
0c5a5a6
Merge branch 'main' into remove-cpu-limits-from-tasks
enkeefe00 Jan 16, 2025
9d566a0
Merge branch 'main' into remove-cpu-limits-from-tasks
enkeefe00 Jan 17, 2025
eb20d71
Merge branch 'main' into remove-cpu-limits-from-tasks
enkeefe00 Jan 20, 2025
85c2dda
Merge branch 'main' into remove-cpu-limits-from-tasks
enkeefe00 Jan 22, 2025
967a078
Merge branch 'main' into remove-cpu-limits-from-tasks
enkeefe00 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion task-generator/trusted-artifacts/golden/git-clone/ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ spec:
value: $(params.ociArtifactExpiresAfter)
computeResources:
limits:
cpu: "1"
memory: 3Gi
requests:
cpu: "1"
Expand Down
1 change: 0 additions & 1 deletion task-generator/trusted-artifacts/golden/prefetch-dependencies/ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ spec:
value: $(params.ociArtifactExpiresAfter)
computeResources:
limits:
cpu: "1"
memory: 3Gi
requests:
cpu: "1"
Expand Down
1 change: 0 additions & 1 deletion task-generator/trusted-artifacts/ta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,6 @@ func perform(task *pipeline.Task, recipe *Recipe) error {
core.ResourceMemory: resource.MustParse("3Gi"),
},
Limits: core.ResourceList{
core.ResourceCPU: resource.MustParse("1"),
core.ResourceMemory: resource.MustParse("3Gi"),
},
},
Expand Down
2 changes: 0 additions & 2 deletions task/build-image-index/0.1/build-image-index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ spec:
computeResources:
limits:
memory: 512Mi
cpu: 200m
requests:
memory: 256Mi
cpu: 100m
Expand Down Expand Up @@ -213,7 +212,6 @@ spec:
computeResources:
limits:
memory: 512Mi
cpu: 200m
requests:
memory: 256Mi
cpu: 100m
3 changes: 0 additions & 3 deletions task/build-maven-zip-oci-ta/0.1/build-maven-zip-oci-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ spec:
fi
computeResources:
limits:
cpu: "4"
memory: 8Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -167,7 +166,6 @@ spec:
fi
computeResources:
limits:
cpu: "4"
memory: 8Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -202,7 +200,6 @@ spec:
echo -n "${sbom_repo}:${sbom_tag}" | tee "$(results.SBOM_BLOB_URL.path)"
computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down
3 changes: 0 additions & 3 deletions task/build-maven-zip/0.1/build-maven-zip.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ spec:
computeResources:
limits:
memory: 8Gi
cpu: '4'
requests:
memory: 2Gi
cpu: '1'
Expand Down Expand Up @@ -107,7 +106,6 @@ spec:
computeResources:
limits:
memory: 8Gi
cpu: '4'
requests:
memory: 2Gi
cpu: '1'
Expand Down Expand Up @@ -169,7 +167,6 @@ spec:
computeResources:
limits:
memory: 512Mi
cpu: 200m
requests:
memory: 256Mi
cpu: 100m
Expand Down
4 changes: 0 additions & 4 deletions task/build-paketo-builder-oci-ta/0.1/build-paketo-builder-oci-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,6 @@ spec:
workingDir: /var/workdir
- computeResources:
limits:
cpu: "2"
memory: 4Gi
requests:
cpu: 500m
Expand All @@ -337,7 +336,6 @@ spec:
workingDir: /var/workdir/source
- computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down Expand Up @@ -374,7 +372,6 @@ spec:
workingDir: /var/workdir
- computeResources:
limits:
cpu: "4"
memory: 4Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -470,7 +467,6 @@ spec:
workingDir: /var/workdir
- computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down
3 changes: 0 additions & 3 deletions task/buildah-24gb/0.2/patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
- op: replace
path: /spec/steps/0/computeResources/requests/memory
value: 20Gi
- op: replace
path: /spec/steps/0/computeResources/limits/cpu
value: "20"
- op: replace
path: /spec/steps/0/computeResources/requests/cpu
value: "10"
Expand Down
15 changes: 0 additions & 15 deletions task/buildah-min/0.2/patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
- op: replace
path: /spec/steps/0/computeResources/requests/memory
value: 1Gi
- op: replace
path: /spec/steps/0/computeResources/limits/cpu
value: 2
- op: replace
path: /spec/steps/0/computeResources/requests/cpu
value: 100m
Expand All @@ -21,9 +18,6 @@
- op: replace
path: /spec/stepTemplate/computeResources/requests/memory
value: 512Mi
- op: replace
path: /spec/stepTemplate/computeResources/limits/cpu
value: 500m
- op: replace
path: /spec/stepTemplate/computeResources/requests/cpu
value: 100m
Expand All @@ -34,9 +28,6 @@
- op: replace
path: /spec/steps/4/computeResources/requests/memory
value: 128Mi
- op: replace
path: /spec/steps/4/computeResources/limits/cpu
value: 100m
- op: replace
path: /spec/steps/4/computeResources/requests/cpu
value: 10m
Expand All @@ -47,9 +38,6 @@
- op: replace
path: /spec/steps/5/computeResources/requests/memory
value: 128Mi
- op: replace
path: /spec/steps/5/computeResources/limits/cpu
value: 100m
- op: replace
path: /spec/steps/5/computeResources/requests/cpu
value: 10m
Expand All @@ -60,9 +48,6 @@
- op: replace
path: /spec/steps/6/computeResources/requests/memory
value: 512Mi
- op: replace
path: /spec/steps/6/computeResources/limits/cpu
value: 2
- op: replace
path: /spec/steps/6/computeResources/requests/cpu
value: 100m
4 changes: 0 additions & 4 deletions task/buildah-oci-ta/0.3/buildah-oci-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ spec:
stepTemplate:
computeResources:
limits:
cpu: "4"
memory: 4Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -561,7 +560,6 @@ spec:
done
computeResources:
limits:
cpu: "4"
memory: 8Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -709,7 +707,6 @@ spec:
--base-images-digests=/shared/base_images_digests
computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down Expand Up @@ -746,7 +743,6 @@ spec:
echo -n "${sbom_repo}@sha256:${sbom_digest}" | tee "$(results.SBOM_BLOB_URL.path)"
computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down
4 changes: 0 additions & 4 deletions task/buildah-remote-oci-ta/0.3/buildah-remote-oci-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ spec:
stepTemplate:
computeResources:
limits:
cpu: "4"
memory: 4Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -240,7 +239,6 @@ spec:
- $(params.LABELS[*])
computeResources:
limits:
cpu: "4"
memory: 8Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -797,7 +795,6 @@ spec:
workingDir: /var/workdir/source
- computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down Expand Up @@ -848,7 +845,6 @@ spec:
workingDir: /var/workdir
- computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down
4 changes: 0 additions & 4 deletions task/buildah-remote/0.3/buildah-remote.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ spec:
stepTemplate:
computeResources:
limits:
cpu: "4"
memory: 4Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -222,7 +221,6 @@ spec:
- $(params.LABELS[*])
computeResources:
limits:
cpu: "4"
memory: 8Gi
requests:
cpu: "1"
Expand Down Expand Up @@ -773,7 +771,6 @@ spec:
workingDir: $(workspaces.source.path)/source
- computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down Expand Up @@ -824,7 +821,6 @@ spec:
workingDir: $(workspaces.source.path)
- computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down
4 changes: 0 additions & 4 deletions task/buildah/0.3/buildah.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ spec:
computeResources:
limits:
memory: 4Gi
cpu: '4'
requests:
memory: 1Gi
cpu: '1'
Expand Down Expand Up @@ -194,7 +193,6 @@ spec:
computeResources:
limits:
memory: 8Gi
cpu: '4'
requests:
memory: 2Gi
cpu: '1'
Expand Down Expand Up @@ -617,7 +615,6 @@ spec:
computeResources:
limits:
memory: 512Mi
cpu: 200m
requests:
memory: 256Mi
cpu: 100m
Expand Down Expand Up @@ -687,7 +684,6 @@ spec:
computeResources:
limits:
memory: 512Mi
cpu: 200m
requests:
memory: 256Mi
cpu: 100m
Expand Down
3 changes: 0 additions & 3 deletions task/clair-scan/0.2/clair-scan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ spec:
computeResources:
limits:
memory: 512Mi
cpu: 200m
requests:
memory: 256Mi
cpu: 100m
Expand Down Expand Up @@ -84,7 +83,6 @@ spec:
computeResources:
limits:
memory: 4Gi
cpu: '2'
requests:
memory: 1Gi
cpu: 500m
Expand Down Expand Up @@ -185,7 +183,6 @@ spec:
computeResources:
limits:
memory: 2Gi
cpu: 500m
requests:
memory: 256Mi
cpu: 100m
Expand Down
2 changes: 0 additions & 2 deletions task/clamav-scan/0.2/clamav-scan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ spec:
computeResources:
limits:
memory: 8Gi
cpu: '2'
requests:
memory: 2Gi
cpu: 500m
Expand Down Expand Up @@ -167,7 +166,6 @@ spec:
computeResources:
limits:
memory: 512Mi
cpu: 200m
requests:
memory: 256Mi
cpu: 100m
Expand Down
2 changes: 0 additions & 2 deletions task/fbc-fips-check-oci-ta/0.1/fbc-fips-check-oci-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ spec:
echo "${images_processed_template/\[%s]/[$digests_processed_string]}" >"/tekton/home/images_processed.txt"
computeResources:
limits:
cpu: "2"
memory: 8Gi
requests:
cpu: "1"
Expand All @@ -186,7 +185,6 @@ spec:
- name: fips-operator-check-step-action
computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down
2 changes: 0 additions & 2 deletions task/fbc-fips-check/0.1/fbc-fips-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ spec:
computeResources:
limits:
memory: 8Gi
cpu: '2'
requests:
memory: 8Gi
cpu: '1'
Expand Down Expand Up @@ -172,7 +171,6 @@ spec:
computeResources:
limits:
memory: 512Mi
cpu: 200m
requests:
memory: 256Mi
cpu: 100m
Expand Down
2 changes: 0 additions & 2 deletions task/fips-operator-bundle-check-oci-ta/0.1/fips-operator-bundle-check-oci-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ spec:
echo "${images_processed_template/\[%s]/[$digests_processed_string]}" >/tekton/home/images_processed.txt
computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand All @@ -152,7 +151,6 @@ spec:
- name: fips-operator-check-step-action
computeResources:
limits:
cpu: 200m
memory: 512Mi
requests:
cpu: 100m
Expand Down
Loading
Loading