Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve magefiles to allow to run Konflux jobs from a push event type instead of only Pull Requests #1514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

flacatus
Copy link
Collaborator

Description

This Pull Request prepares the e2e repo to accept tests that are coming from a push event in tekton. This will help to run the e2e tests preiodically

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@flacatus flacatus requested a review from psturc February 18, 2025 08:20
@openshift-ci openshift-ci bot requested a review from Dannyb48 February 18, 2025 08:20
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from flacatus. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus flacatus changed the title Periodics kx feat: Improve magefiles to allow to run Konflux jobs from a push event type instead of only Pull Requests Feb 18, 2025
@konflux-ci-qe-bot
Copy link

@flacatus: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-728d9 Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-728d9

Test results analysis

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

➡️ [failed] [It] [build-service-suite Build service E2E tests] test build secret lookup when two secrets are created triggered PipelineRun is for component [build-service, pac-build, secret-lookup]

Click to view logs

Timed out after 300.000s.
timed out when waiting for the PipelineRun to start for the component component-two-vmcx/build-e2e-bnmd-tenant
Expected success, but got an error:
    <*errors.errorString | 0xc000dde2e0>: 
    no pipelinerun found for component component-two-vmcx
    {
        s: "no pipelinerun found for component component-two-vmcx",
    }

➡️ [failed] [It] [build-service-suite Build templates E2E test] HACBS pipelines when Pipeline Results are stored for component with Git source URL https://github.com/redhat-appstudio-qe/devfile-sample-python-basic and Pipeline docker-build should have Pipeline Records [build, build-templates, HACBS, pipeline]

Click to view logs

No records found for PipelineRun test-comp-gykm-on-pull-request-p2w8q
Expected
    <[]pipeline.Record | len:0, cap:0>: []
not to be empty

➡️ [failed] [It] [enterprise-contract-suite Enterprise Contract E2E tests] test creating and signing an image and task verify-enterprise-contract task Release Policy verifies redhat products pass the redhat policy rule collection before release [ec, pipeline]

Click to view logs

Expected
    <[]v1.TaskRunResult | len:1, cap:4>: [
        {
            Name: "TEST_OUTPUT",
            Type: "string",
            Value: {
                Type: "string",
                StringVal: "{\"timestamp\":\"1739873338\",\"namespace\":\"\",\"successes\":320,\"failures\":2,\"warnings\":12,\"result\":\"FAILURE\"}\n",
                ArrayVal: nil,
                ObjectVal: nil,
            },
        },
    ]
not to contain elements
    <[]*tekton.TaskRunResultMatcher | len:1, cap:1>: [
        {
            name: "TEST_OUTPUT",
            jsonPath: "{$.result}",
            value: nil,
            jsonValue: "[\"FAILURE\"]",
            jsonMatcher: <*matchers.MatchJSONMatcher | 0xc0018c2f00>{
                JSONToMatch: "[\"FAILURE\"]",
                firstFailurePath: nil,
            },
        },
    ]

2. When testing in openshift/release repo
3. When a integration test is coming from Konflux with a push event_type
*/
if jobType == "periodic" || strings.Contains(jobName, "rehearse") || konfluxCiSpec.KonfluxGitRefs.EventType == "push" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't initialize the config for konflux periodic jobs, we won't be able to identify for which component the periodic job runs for, no? so by default, all tests suites will run for build-service, integration-service etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants