-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve magefiles to allow to run Konflux jobs from a push event type instead of only Pull Requests #1514
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@flacatus: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-728d9 Test results analysis🚨 Error occurred while running the E2E tests, list of failed Spec(s): ➡️ [ Click to view logsTimed out after 300.000s. timed out when waiting for the PipelineRun to start for the component component-two-vmcx/build-e2e-bnmd-tenant Expected success, but got an error: <*errors.errorString | 0xc000dde2e0>: no pipelinerun found for component component-two-vmcx { s: "no pipelinerun found for component component-two-vmcx", } ➡️ [ Click to view logsNo records found for PipelineRun test-comp-gykm-on-pull-request-p2w8q Expected <[]pipeline.Record | len:0, cap:0>: [] not to be empty ➡️ [ Click to view logsExpected <[]v1.TaskRunResult | len:1, cap:4>: [ { Name: "TEST_OUTPUT", Type: "string", Value: { Type: "string", StringVal: "{\"timestamp\":\"1739873338\",\"namespace\":\"\",\"successes\":320,\"failures\":2,\"warnings\":12,\"result\":\"FAILURE\"}\n", ArrayVal: nil, ObjectVal: nil, }, }, ] not to contain elements <[]*tekton.TaskRunResultMatcher | len:1, cap:1>: [ { name: "TEST_OUTPUT", jsonPath: "{$.result}", value: nil, jsonValue: "[\"FAILURE\"]", jsonMatcher: <*matchers.MatchJSONMatcher | 0xc0018c2f00>{ JSONToMatch: "[\"FAILURE\"]", firstFailurePath: nil, }, }, ] |
2. When testing in openshift/release repo | ||
3. When a integration test is coming from Konflux with a push event_type | ||
*/ | ||
if jobType == "periodic" || strings.Contains(jobName, "rehearse") || konfluxCiSpec.KonfluxGitRefs.EventType == "push" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we don't initialize the config for konflux periodic jobs, we won't be able to identify for which component the periodic job runs for, no? so by default, all tests suites will run for build-service, integration-service etc...
Description
This Pull Request prepares the e2e repo to accept tests that are coming from a push event in tekton. This will help to run the e2e tests preiodically
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: