Only read access is necessary to view #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have three roles: admin, maintainer, and contributor. The contributor role grants you read-only verbs. As this was previously coded, having contributor rights in a namespace would not be sufficient for it to show up in the workspace switcher. Signed-off-by: Ralph Bean <[email protected]>
|
@ralphbean are we still using workspace-manager somewhere? |
|
Oh, perhaps not? I found my way here by grepping through infra-deployments and guessing. What I'm really looking for is the thing that's responsible for serving the It correctly serves two namespaces for me where I have admin rbac, but it does not serve a third in its response where I have only a "contributor" read-only role. |
|
In infra-deployments, I see: |
Oh. Was not expecting that in production anywhere. |
yftacherzog
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have three roles: admin, maintainer, and contributor.
The contributor role grants you read-only verbs.
As this was previously coded, having contributor rights in a namespace would not be sufficient for it to show up in the workspace switcher.