Skip to content

fix(notifications): don't require login and password to allow using S… #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

anaxita
Copy link
Contributor

@anaxita anaxita commented Mar 14, 2025

Don't require login and password for SMTP to omit using auth (and upgrading to SMTPs) to allow using just SMTP (for only internal smtp servers for example)

@anaxita
Copy link
Contributor Author

anaxita commented Mar 14, 2025

In server if login and pass was provided it requires TLS upgrade for server because it starts using plain auth (client send START TLS)

https://github.com/kopia/kopia/blob/9b68189d29efe4c8b548d67b3c7a37e4f65770ae/notification/sender/email/email_sender.go#L27-L29

@anaxita anaxita force-pushed the do-not-require-plain-auth branch from 1f22cba to 0da62bc Compare May 1, 2025 09:23
@jkowalski jkowalski merged commit af6ad6d into kopia:main May 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants