feat: Add xoxp/xoxb token support for conversations_unreads #199
+558
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rieval - Uses ClientUserBoot to get all channels with LastRead/Latest in one API call - Filters channels where Latest > LastRead to find unreads - Prioritizes: DMs > group DMs > partner channels (ext-*) > internal - Only fetches message history for channels with actual unreads - Supports filtering by channel type and configurable limits Addresses issue korotovsky#114
- Switch from ClientUserBoot to ClientCounts API - ClientCounts returns HasUnreads boolean for all channels - Add ClientCounts to SlackAPI interface - Process Channels, MPIMs, and IMs separately
- Strip existing # prefix before adding to avoid ##name - Use stripped name for ext-/shared- prefix checks for partner type
- Add mentions_only parameter to conversations_unreads to filter channels to only those with @mentions (priority inbox) - Add conversations_mark tool to mark channels/DMs as read - Supports channel IDs, #channel names, and @username - If no timestamp provided, marks all messages as read
…nels - Add IsExtShared field to Channel struct in cache - Pass IsExtShared through mapChannel function - Use cached.IsExtShared to identify external/partner channels instead of checking for ext-/shared- name prefixes Note: Users may need to delete their channels cache file to repopulate with the new IsExtShared field.
- Extract handler params to structs with parsing functions (unreadsParams, markParams) following existing patterns - Add SLACK_MCP_MARK_TOOL env var guard for conversations_mark (disabled by default, requires explicit opt-in) - Remove unused categorizeChannel and getChannelDisplayName functions - Update README with conversations_mark safety note and env var docs
Adds fallback implementation for conversations_unreads tool that works with xoxp and xoxb tokens by iterating through channels and using conversations.info to check unread_count. The ClientCounts API (used in the original implementation) only works with browser session tokens (xoxc/xoxd) and returns empty results for OAuth tokens (xoxp/xoxb). This change detects when ClientCounts returns empty results and automatically falls back to the per-channel approach. Implementation details: - Added GetConversationInfoContext to SlackAPI interface - New helper method getUnreadsUsingConversationsInfo implements xoxp approach - Automatically detects empty ClientCounts response and switches to fallback - Logs info message when using fallback method - Maintains same output format and filtering options as original - Note: mentions_only filter not supported with xoxp (logged as warning) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Author
|
Approach was merged into #171 so I am closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds fallback implementation for
conversations_unreadstool that works with xoxp and xoxb tokens.This PR is stacked on top of #171 and includes those commits. It should be reviewed after #171 is merged, or reviewed with the understanding that it builds upon that PR's functionality.
Problem
The current implementation of
conversations_unreads(from #171) uses theClientCountsAPI, which only works with browser session tokens (xoxc/xoxd). When used with OAuth tokens (xoxp/xoxb), it executes without error but returns empty results.Solution
This PR adds an automatic fallback that:
ClientCountsfirst (fast path for xoxc/xoxd)ClientCountsreturns empty resultsconversations.infoto checkunread_counton each channelThis approach was validated in a Python implementation before porting to Go.
Implementation Details
getUnreadsUsingConversationsInfoimplements the per-channel approachClientCountsreturns zero channels and switches to fallbackGetConversationInfoContexttoSlackAPIinterfaceLimitations with xoxp/xoxb tokens
mentions_onlyfilter is not supported (no access to mention counts viaconversations.info)mentions_onlyis requestedlastReadandlatesttimestamps are not available viaconversations.info(returned as empty strings)ClientCountsapproach as it requires one API call per channelTesting
Related
🤖 Generated with Claude Code