Skip to content

Cleaning requirements, and simplifying codecov / testing env #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
# Python CircleCI 2.0 configuration file
#
# Check https://circleci.com/docs/2.0/language-python/ for more details
#
version: 2
jobs:
build:
docker:
- image: circleci/python:latest
- image: circleci/python:3.8.6

working_directory: ~/talkgenerator

Expand All @@ -26,7 +22,7 @@ jobs:
python3 -m venv venv
. venv/bin/activate
pip install --upgrade pip setuptools
python3 -m pip install -r requirements.txt --use-feature=2020-resolver
python3 -m pip install -r requirements.txt
python run_nltk_download.py

- save_cache:
Expand All @@ -40,13 +36,10 @@ jobs:
command: |
python3 -m venv venv
. venv/bin/activate
pip install --upgrade pip setuptools
pip install pytest
pip install pytest-cov
pip install codecov
pip install --upgrade pip setuptools pytest-cov codecov
pytest --cov=talkgenerator tests/
codecov --token=e25ce249-b3da-4d80-b8d3-074f7d288969

- store_artifacts:
path: test-reports
destination: test-reports
destination: test-reports
62 changes: 12 additions & 50 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,50 +1,12 @@
appdirs==1.4.4
attrs==20.1.0
beautifulsoup4==4.9.1
black==21.7b0
certifi==2020.6.20
chardet==3.0.4
charset-normalizer==2.0.4
click==7.1.2
codecov==2.1.9
coverage==5.2.1
environs==8.0.0
idna==2.10
importlib-metadata==1.7.0
inflect==4.1.0
iniconfig==1.0.1
joblib==0.16.0
lxml==4.6.3
marshmallow==3.7.1
more-itertools==8.5.0
mypy-extensions==0.4.3
nltk>=3.6.4
packaging==20.4
pathspec==0.9.0
pathtools==0.1.2
pexels-api==1.0.1
Pillow==8.3.2
pluggy==0.13.1
portalocker==2.0.0
praw==7.5.0
py==1.10.0
pyparsing==2.4.7
pytest==6.0.1
pytest-cov==2.10.1
python-dotenv==0.14.0
python-pptx==0.6.18
pyunsplash==1.0.0b9
regex
requests==2.24.0
six==1.15.0
soupsieve==2.0.1
toml==0.10.1
tomli==1.2.1
tqdm==4.48.2
tracery==0.1.1
update-checker==0.18.0
urllib3==1.25.10
watchdog==0.10.3
websocket-client==0.57.0
XlsxWriter==1.3.3
zipp==3.1.0
cachier
python-pptx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if adding the dependencies with a ">=" (e.g. python-pptx>=0.6.18) might be useful in case some of them have major updates.

pexels_api
environs
requests
bs4
tracery
inflect
nltk
pyunsplash
praw
pytest-cov
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,5 @@
("text-templates", all_text_templates),
],
include_package_data=True,
install_requires=required,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for removing these dependencies from setup.py?

entry_points={"console_scripts": ["talkgenerator = talkgenerator.run:main_cli"]},
)