Skip to content

allow snapshotting one k8s namespace without scanning all namespaces #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sami-alajrami merged 1 commit into from
Dec 16, 2024
Merged

allow snapshotting one k8s namespace without scanning all namespaces #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 5 additions & 58 deletions internal/kube/kube.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,24 +102,6 @@ func (clientset *K8SConnection) GetPodsData(filter *filters.ResourceFilterOption
return podsData, fmt.Errorf("could not filter namespaces: %v ", err)
}

// if len(excludeNamespaces) > 0 {
// filteredNamespaces, err = filterNamespaces(nsList.Items, excludeNamespaces, "exclude")
// if err != nil {
// return podsData, fmt.Errorf("could not filter namespaces: %v ", err)
// }
// } else if len(includNamespaces) == 0 {
// var err error
// list, err = clientset.CoreV1().Pods("").List(ctx, metav1.ListOptions{})
// if err != nil {
// return podsData, fmt.Errorf("could not list pods on cluster scope: %v ", err)
// }
// } else {
// filteredNamespaces, err = filterNamespaces(nsList.Items, includNamespaces, "include")
// if err != nil {
// return podsData, fmt.Errorf("could not filter namespaces: %v ", err)
// }
// }

logger.Info("scanning the following namespaces: %v ", filteredNamespaces)

// run concurrently
Expand Down Expand Up @@ -191,6 +173,11 @@ func processPods(list *corev1.PodList) []*PodData {

// filterNamespaces filters a super set of namespaces by including or excluding a subset of namespaces using regex patterns.
func (clientset *K8SConnection) filterNamespaces(filter *filters.ResourceFilterOptions) ([]string, error) {
if len(filter.IncludeNamesRegex) == 0 && len(filter.ExcludeNamesRegex) == 0 {
if len(filter.IncludeNames) > 0 {
return filter.IncludeNames, nil
}
}
result := []string{}
// get all namespaces in the cluster
nsList, err := clientset.GetClusterNamespaces()
Expand Down Expand Up @@ -241,46 +228,6 @@ func (clientset *K8SConnection) filterNamespaces(filter *filters.ResourceFilterO
result = append(result, ns)
mutex.Unlock()
}

// match := false
// for _, p := range patterns {
// r, err := regexp.Compile(p)
// if err != nil {
// select {
// case errs <- fmt.Errorf("failed to compile regex pattern %v : %v", p, err):
// default:
// }
// cancel() // send cancel signal to goroutines
// return
// }
// if r.MatchString(ns) {
// match = true
// break
// }
// }
// switch operation {
// case "include":
// if match {
// mutex.Lock()
// result = append(result, ns)
// mutex.Unlock()
// }
// case "exclude":
// if !match {
// mutex.Lock()
// result = append(result, ns)
// mutex.Unlock()
// }

// default:
// select {
// case errs <- fmt.Errorf("unsupported operation %s", operation):
// default:
// }
// cancel() // send cancel signal to goroutines
// return

// }
}(ns.Name)
}
wg.Wait()
Expand Down