Conversation
Contributor
sami-alajrami
left a comment
sami-alajrami
left a comment
There was a problem hiding this comment.
linting sends reports to kosli regardless of the report_results flag value
Contributor
Author
Hmm, I hadn't considered that we (one day) might want to run the lint (and snyk code) tests but not report the results. Have added the extra conditional. |
sami-alajrami
approved these changes
Feb 27, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Turn off reporting to Kosli and Docker build/snyk scan * Add accidentally-removed sonarqube_token back in * Small refactoring * Move daily tests to separate workflow * Change name of new daily workflow * Make sure snyk code scans not run when we do a release * Replace Bitbucket username/password with access token in daily workflow * Only send lint and snyk code results to Kosli if send_results flag set in test workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.