Skip to content

Don't show api-token,host,org,flow,trail in example use cases#463

Merged
JonJagger merged 3 commits intomainfrom
simplify-example-use-cases
Mar 11, 2025
Merged

Don't show api-token,host,org,flow,trail in example use cases#463
JonJagger merged 3 commits intomainfrom
simplify-example-use-cases

Conversation

@JonJagger
Copy link
Contributor

@JonJagger JonJagger commented Mar 11, 2025

Billy created a document for Emburse using chat gpt. It looks like AI is being influenced by the examples at the end of each CLI command at https://docs.kosli.com/

This commit:

  • removes flags that would commonly be set via environment-variables. Specifically, --api-token, --host, --org, --flow, --trail.
  • adds some text explaining the assumption that these are set via env-vars in the examples.
  • removes the trailing backslashes.

Note: It does this in the docs processing of the source .go files. In other words, the flags still exist in the original source in case we wish to undo this change.

Before

Screenshot 2025-03-11 at 12 27 31

After

Screenshot 2025-03-11 at 12 29 04

@JonJagger JonJagger enabled auto-merge March 11, 2025 12:57
@JonJagger JonJagger merged commit ce62013 into main Mar 11, 2025
6 checks passed
@JonJagger JonJagger deleted the simplify-example-use-cases branch March 11, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants