Add pagination to list trails

[FayeSGW]

No description provided.

[sami-alajrami]

there are some flag duplication and some inconsistencies with how other list commands (e.g. list artifacts) commands work.
I get it about backward compatibility for returning all trails on the API, although not sure if we need it on the CLI. You can keep the backward compatability but reuse the addListFlags func after adding a param for a custom default.

you can modify that func like this:

func addListFlags(cmd *cobra.Command, o *listOptions, customPageLimit ...int) {
    cmd.Flags().StringVarP(&o.output, "output", "o", "table", outputFlag)
    cmd.Flags().IntVar(&o.pageNumber, "page", 1, pageNumberFlag)

    // Use customPageLimit if provided, otherwise default to 15
    pageLimit := 15
    if len(customPageLimit) > 0 {
        pageLimit = customPageLimit[0]
    }
    
    cmd.Flags().IntVarP(&o.pageLimit, "page-limit", "n", pageLimit, pageLimitFlag)
}

[sami-alajrami]

is this if needed? what happens if we send per_page=0 to the API? and how are we maintaining backward compatibility there?

[FayeSGW]

It looks like if we send per_page=0 then the API returns all results, so we could get away without this. I'm just not sure why it returns all the results, so it makes me uncomfortable :P

In the API, if no parameter is provided for per_page (which is not defaulted) then it behaves the same as it does now, which should ensure the backwards compatibility.

With the modified function above - I'm not sure that will work, because we need there to be no default for the pageLimit for list trails (or a default of 0 if none is provided with the flag). Your function defaults to 15 if none is provided, which won't work.

[sami-alajrami]

With the modified function above - I'm not sure that will work, because we need there to be no default for the pageLimit for list trails (or a default of 0 if none is provided with the flag). Your function defaults to 15 if none is provided, which won't work.

yes, the modified version of the function above adds the optional arg customPageLimit which you can set to 0 without modifying other calls of that function.